From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F6F6C433B4 for ; Wed, 12 May 2021 13:36:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD7C7613D6 for ; Wed, 12 May 2021 13:36:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230145AbhELNhT (ORCPT ); Wed, 12 May 2021 09:37:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:47326 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230213AbhELNhR (ORCPT ); Wed, 12 May 2021 09:37:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4A08C613DA; Wed, 12 May 2021 13:36:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620826568; bh=IWZVvgBx3j7K8GWviGoztvAzsheerKNafMdt9ZDKe9k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KddmOLsT4uN+dWt8Eoso3Pbzk9bjHom0623lZ48XJ3tIhbboUv3Mw6MgpS6rtWNwz dnKEwhwvaF4vUXA4vri5ZJcOevra2aU1zYnUFNE8tezomdVlDlX4lww6D3B+KYjGnb uy6fGAp15QMABg9kPFXomV1n07B17qxhm8B5aHIVOZhlVx6lgzDfeax3RAZMhglSti knerGnE78TnwVkcEDRkV8Z7GsKifRU1cTDNiDfjPK9mdM4z7CbuUrtljSoO0QxU00Y TENoGsSKKMK075BN3YymCyIRueSQVTjqTXsO++Pu/lYRl3JG8r2Q8SzwH8JhYct2Uw jMzH0tCxW3cMw== Date: Wed, 12 May 2021 15:36:03 +0200 From: Mauro Carvalho Chehab To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, Julia Lawall , "Rafael J . Wysocki" , Jonathan Cameron , Hans de Goede Subject: Re: [PATCH 04/28] iio: accel: bmc150-accel: Balanced runtime pm + use pm_runtime_resume_and_get() Message-ID: <20210512153603.6790f26c@coco.lan> In-Reply-To: <20210509113354.660190-5-jic23@kernel.org> References: <20210509113354.660190-1-jic23@kernel.org> <20210509113354.660190-5-jic23@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Em Sun, 9 May 2021 12:33:30 +0100 Jonathan Cameron escreveu: > From: Jonathan Cameron > > A call to pm_runtime_put_noidle() doesn't match any call that would > result in a get(). It is safe because runtime pm core protects against > the reference counter going 0, but it makes it harder to understand the > code. > > Whilst here use pm_runtime_resume_and_get() to tidy things up. > The Coccinelle script didn't get this one due to more complex code > structure. > > Signed-off-by: Jonathan Cameron > Cc: Hans de Goede LGTM. Reviewed-by: Mauro Carvalho Chehab > --- > drivers/iio/accel/bmc150-accel-core.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc150-accel-core.c > index 62a164a7b852..43cfadf8f6b7 100644 > --- a/drivers/iio/accel/bmc150-accel-core.c > +++ b/drivers/iio/accel/bmc150-accel-core.c > @@ -389,7 +389,7 @@ static int bmc150_accel_set_power_state(struct bmc150_accel_data *data, bool on) > int ret; > > if (on) { > - ret = pm_runtime_get_sync(dev); > + ret = pm_runtime_resume_and_get(dev); > } else { > pm_runtime_mark_last_busy(dev); > ret = pm_runtime_put_autosuspend(dev); > @@ -398,9 +398,6 @@ static int bmc150_accel_set_power_state(struct bmc150_accel_data *data, bool on) > if (ret < 0) { > dev_err(dev, > "Failed: %s for %d\n", __func__, on); > - if (on) > - pm_runtime_put_noidle(dev); > - > return ret; > } > > @@ -1836,7 +1833,6 @@ int bmc150_accel_core_remove(struct device *dev) > > pm_runtime_disable(dev); > pm_runtime_set_suspended(dev); > - pm_runtime_put_noidle(dev); > > bmc150_accel_unregister_triggers(data, BMC150_ACCEL_TRIGGERS - 1); > Thanks, Mauro