From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org
Cc: Alexandru Ardelean <aardelean@deviqon.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Jacopo Mondi <jacopo@jmondi.org>
Subject: [PATCH 2/8] iio: adc: max11100: Use devm_ functions for rest of probe()
Date: Sun, 16 May 2021 18:25:14 +0100 [thread overview]
Message-ID: <20210516172520.1398835-3-jic23@kernel.org> (raw)
In-Reply-To: <20210516172520.1398835-1-jic23@kernel.org>
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
By using devm_add_action_or_reset() to manage the regulator disable,
it becomes simple to use managed functions for all of remove.
This simplifies error handling and allows us to drop the remove()
function entirely.
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Jacopo Mondi <jacopo@jmondi.org>
---
drivers/iio/adc/max11100.c | 29 +++++++++--------------------
1 file changed, 9 insertions(+), 20 deletions(-)
diff --git a/drivers/iio/adc/max11100.c b/drivers/iio/adc/max11100.c
index 69d607fa17aa..9951f6a6a4b9 100644
--- a/drivers/iio/adc/max11100.c
+++ b/drivers/iio/adc/max11100.c
@@ -102,6 +102,11 @@ static const struct iio_info max11100_info = {
.read_raw = max11100_read_raw,
};
+static void max11100_regulator_disable(void *reg)
+{
+ regulator_disable(reg);
+}
+
static int max11100_probe(struct spi_device *spi)
{
int ret;
@@ -131,27 +136,12 @@ static int max11100_probe(struct spi_device *spi)
if (ret)
return ret;
- ret = iio_device_register(indio_dev);
+ ret = devm_add_action_or_reset(&spi->dev, max11100_regulator_disable,
+ state->vref_reg);
if (ret)
- goto disable_regulator;
-
- return 0;
-
-disable_regulator:
- regulator_disable(state->vref_reg);
-
- return ret;
-}
-
-static int max11100_remove(struct spi_device *spi)
-{
- struct iio_dev *indio_dev = spi_get_drvdata(spi);
- struct max11100_state *state = iio_priv(indio_dev);
-
- iio_device_unregister(indio_dev);
- regulator_disable(state->vref_reg);
+ return ret;
- return 0;
+ return devm_iio_device_register(&spi->dev, indio_dev);
}
static const struct of_device_id max11100_ids[] = {
@@ -166,7 +156,6 @@ static struct spi_driver max11100_driver = {
.of_match_table = max11100_ids,
},
.probe = max11100_probe,
- .remove = max11100_remove,
};
module_spi_driver(max11100_driver);
--
2.31.1
next prev parent reply other threads:[~2021-05-16 17:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-16 17:25 [PATCH 0/8] iio: adc: Maxim and TI ADC driver cleanups Jonathan Cameron
2021-05-16 17:25 ` [PATCH 1/8] iio: adc: max11100: Use get_unaligned_be16() rather than opencoding Jonathan Cameron
2021-05-17 6:59 ` Alexandru Ardelean
2021-05-16 17:25 ` Jonathan Cameron [this message]
2021-05-17 7:08 ` [PATCH 2/8] iio: adc: max11100: Use devm_ functions for rest of probe() Alexandru Ardelean
2021-05-17 7:22 ` Alexandru Ardelean
2021-05-16 17:25 ` [PATCH 3/8] iio: adc: max1118: Use devm_ managed functions for all of probe Jonathan Cameron
2021-05-17 7:18 ` Alexandru Ardelean
2021-05-16 17:25 ` [PATCH 4/8] iio: adc: max1118: Avoid jumping back and forth between spi and iio structures Jonathan Cameron
2021-05-17 7:24 ` Alexandru Ardelean
2021-05-16 17:25 ` [PATCH 5/8] iio: adc: ti-adc081c: Use devm managed functions for all of probe() Jonathan Cameron
2021-05-17 7:26 ` Alexandru Ardelean
2021-05-16 17:25 ` [PATCH 6/8] iio: adc: ti-adc0832: " Jonathan Cameron
2021-05-17 7:28 ` Alexandru Ardelean
2021-05-16 17:25 ` [PATCH 7/8] iio: adc: ti-adc108s102: " Jonathan Cameron
2021-05-17 7:31 ` Alexandru Ardelean
2021-05-17 7:37 ` Alexandru Ardelean
2021-05-22 18:29 ` Jonathan Cameron
2021-05-16 17:25 ` [PATCH 8/8] iio: adc: ti-adc161s626: Use devm managed functions for all of probe Jonathan Cameron
2021-05-16 20:04 ` Matt Ranostay
2021-05-17 7:35 ` Alexandru Ardelean
2021-05-22 18:31 ` [PATCH 0/8] iio: adc: Maxim and TI ADC driver cleanups Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210516172520.1398835-3-jic23@kernel.org \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=aardelean@deviqon.com \
--cc=jacopo@jmondi.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox