Re: [PATCH v2 0/4] iio: Drop use of %hhx and %hx format strings

[Jonathan Cameron <Jonathan.Cameron@Huawei.com>]

Hi All,

Not quite sure how I managed to cc Nathan on the patches, but not the
cover letter.  Anyhow +Cc Nathan.

@Nathan. I dropped the tags you gave to v1 as described below, but
it's not a huge change. Very much appreciated if you could take a quick look.

Input from others also appreciated!

Thanks,

Jonathan


On Thu,  3 Jun 2021 19:06:08 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> A wrong use of one of these in
> https://lore.kernel.org/linux-iio/20210514135927.2926482-1-arnd@kernel.org/
> included a reference from Nathan to a patch discouraging the use of
> these strings in general:
> https://lore.kernel.org/lkml/CAHk-=wgoxnmsj8GEVFJSvTwdnWm8wVJthefNk2n6+4TC=20e0Q@mail.gmail.com/
> 
> I did a quick grep and established we only have a few instances of these in
> IIO anyway, so in the interests of avoiding those existing cases getting
> cut and paste into new drivers, let's just clear them out now.
> 
> Note that patch from Arnd is now also part of this series, due to the
> length specifier related issue Joe raised.
> 
> I have chosen to go with 0x%02x rather than %#04x as I find it more readable.
> 
> V2:
> Use 0x%02x (Joe Perches)
> Include Arnd's original patch, modified for the above.
> 
> Arnd Bergmann (1):
>   iio: si1133: fix format string warnings
> 
> Jonathan Cameron (3):
>   iio: light: si1133: Drop remaining uses of %hhx format string.
>   iio: imu: inv_mpu6050: Drop use of %hhx format string.
>   iio: light: si1145: Drop use of %hhx format specifier.
> 
>  drivers/iio/imu/inv_mpu6050/inv_mpu_core.c |  5 ++---
>  drivers/iio/light/si1133.c                 | 18 +++++++++---------
>  drivers/iio/light/si1145.c                 | 10 +++++-----
>  3 files changed, 16 insertions(+), 17 deletions(-)
>