From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Chris Lesiak <chris.lesiak@licor.com>
Cc: Jonathan Cameron <jic23@kernel.org>, <linux-iio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: humidity: hdc100x: Add margin to the conversion time
Date: Thu, 10 Jun 2021 10:41:36 +0100 [thread overview]
Message-ID: <20210610104136.00002e4e@Huawei.com> (raw)
In-Reply-To: <20210609193748.1709308-1-chris.lesiak@licor.com>
On Wed, 9 Jun 2021 14:37:48 -0500
Chris Lesiak <chris.lesiak@licor.com> wrote:
> The datasheets have the following note for the conversion time
> specification: "This parameter is specified by design and/or
> characterization and it is not tested in production."
>
> Parts have been seen that require more time to do 14-bit conversions for
> the relative humidity channel. The result is ENXIO due to the address
> phase of a transfer not getting an ACK.
>
> Delay an additional 1 ms per conversion to allow for additional margin.
>
> Signed-off-by: Chris Lesiak <chris.lesiak@licor.com>
Hi Chris
Could you figure out a fixes tag for this one so we can get it backported
into stable?
If not I can probably guess when I catch up with applying patches.
Thanks,
Jonathan
> ---
> drivers/iio/humidity/hdc100x.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c
> index 2a957f19048e..91790aa8beeb 100644
> --- a/drivers/iio/humidity/hdc100x.c
> +++ b/drivers/iio/humidity/hdc100x.c
> @@ -166,7 +166,7 @@ static int hdc100x_get_measurement(struct hdc100x_data *data,
> struct iio_chan_spec const *chan)
> {
> struct i2c_client *client = data->client;
> - int delay = data->adc_int_us[chan->address];
> + int delay = data->adc_int_us[chan->address] + 1000;
> int ret;
> __be16 val;
>
> @@ -316,7 +316,7 @@ static irqreturn_t hdc100x_trigger_handler(int irq, void *p)
> struct iio_dev *indio_dev = pf->indio_dev;
> struct hdc100x_data *data = iio_priv(indio_dev);
> struct i2c_client *client = data->client;
> - int delay = data->adc_int_us[0] + data->adc_int_us[1];
> + int delay = data->adc_int_us[0] + data->adc_int_us[1] + 2000;
> int ret;
>
> /* dual read starts at temp register */
next prev parent reply other threads:[~2021-06-10 9:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 19:37 [PATCH] iio: humidity: hdc100x: Add margin to the conversion time Chris Lesiak
2021-06-10 9:41 ` Jonathan Cameron [this message]
2021-06-10 13:44 ` [PATCH v2] " Chris Lesiak
2021-06-10 13:55 ` Andy Shevchenko
2021-06-11 18:05 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610104136.00002e4e@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=chris.lesiak@licor.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).