From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EA80C48BE0 for ; Fri, 11 Jun 2021 17:29:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31477613D3 for ; Fri, 11 Jun 2021 17:29:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230028AbhFKRbR (ORCPT ); Fri, 11 Jun 2021 13:31:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:36134 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229874AbhFKRbQ (ORCPT ); Fri, 11 Jun 2021 13:31:16 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 652B1613CF; Fri, 11 Jun 2021 17:29:17 +0000 (UTC) Date: Fri, 11 Jun 2021 18:31:11 +0100 From: Jonathan Cameron To: Wei Yongjun Cc: Alexandru Ardelean , , , Hulk Robot Subject: Re: [PATCH -next] iio: dummy: Fix build error when CONFIG_IIO_TRIGGERED_BUFFER is not set Message-ID: <20210611183111.2e44365a@jic23-huawei> In-Reply-To: <20210526180018.66ac9989@jic23-huawei> References: <20210524140536.116224-1-weiyongjun1@huawei.com> <20210526180018.66ac9989@jic23-huawei> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, 26 May 2021 18:00:18 +0100 Jonathan Cameron wrote: > On Mon, 24 May 2021 14:05:36 +0000 > Wei Yongjun wrote: > > > Gcc reports build error when CONFIG_IIO_TRIGGERED_BUFFER is not set: > > > > riscv64-linux-gnu-ld: drivers/iio/dummy/iio_simple_dummy_buffer.o: in function `iio_simple_dummy_configure_buffer': > > iio_simple_dummy_buffer.c:(.text+0x2b0): undefined reference to `iio_triggered_buffer_setup_ext' > > riscv64-linux-gnu-ld: drivers/iio/dummy/iio_simple_dummy_buffer.o: in function `.L0 ': > > iio_simple_dummy_buffer.c:(.text+0x2fc): undefined reference to `iio_triggered_buffer_cleanup' > > > > Fix it by select IIO_TRIGGERED_BUFFER for config IIO_SIMPLE_DUMMY_BUFFER. > > > > Fixes: 738f6ba11800 ("iio: dummy: iio_simple_dummy_buffer: use triggered buffer core calls") > > Reported-by: Hulk Robot > > Signed-off-by: Wei Yongjun > > Thanks, > > Applied to the fixes-togreg branch of iio.git. Change of plan on this one as I haven't yet sent a fixes pull and now we are late in the cycle. I've moved it over to my togreg branch and will line it up for the coming merge window. Sorry for the delay Jonathan > > Jonathan > > > --- > > drivers/iio/dummy/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/iio/dummy/Kconfig b/drivers/iio/dummy/Kconfig > > index 5c5c2f8c55f3..1f46cb9e51b7 100644 > > --- a/drivers/iio/dummy/Kconfig > > +++ b/drivers/iio/dummy/Kconfig > > @@ -34,6 +34,7 @@ config IIO_SIMPLE_DUMMY_BUFFER > > select IIO_BUFFER > > select IIO_TRIGGER > > select IIO_KFIFO_BUF > > + select IIO_TRIGGERED_BUFFER > > help > > Add buffered data capture to the simple dummy driver. > > > > >