From: Jonathan Cameron <jic23@kernel.org>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Peter Meerwald <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
Bastien Nocera <hadess@hadess.net>,
Hans de Goede <hdegoede@redhat.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v3 00/10] iio: accel: bmc150: Add support for BMA253/BMA254
Date: Fri, 11 Jun 2021 18:35:37 +0100 [thread overview]
Message-ID: <20210611183537.40adbfed@jic23-huawei> (raw)
In-Reply-To: <20210611080903.14384-1-stephan@gerhold.net>
On Fri, 11 Jun 2021 10:08:53 +0200
Stephan Gerhold <stephan@gerhold.net> wrote:
> The Bosch BMA253 accelerometer is very similar to both BMA254 and BMA255.
> The current situation is very confusing: BMA254 is supported by the bma180
> driver, but BMA255 is supported by the bmc150-accel driver.
>
> It turns out the bma180 and bmc150-accel drivers have quite some overlap,
> and BMA253/BMA254 would be a bit better supported in bmc150-accel
> (which has support for the motion trigger/interrupt).
>
> This series adds BMA253 support to bmc150-accel and also moves BMA254
> over to bmc150, removing some unnecessary code from the bma180 driver.
>
> In v2 I also sneaked in a small fix for the scale table of BMA222
> to simplify backporting for the stable people.
After cheating a bit and pulling the dependency across from my fixes-togreg
branch (along with the other patches that were there), I can now apply this.
So applied to the fixes-togreg branch of iio.git and pushed out as testing
for 0-day to have a quick poke at it before I let this going into linux-next.
Thanks,
Jonathan
>
> ---
> Changes in v3:
> - Add new "iio: accel: bmc150: Clarify combo modules in Kconfig" patch
> - Sort "one-line" chip name lists as well, not just multi-line ones
>
> v2: https://lore.kernel.org/linux-iio/20210610122126.50504-1-stephan@gerhold.net/
> Changes in v2:
> - Add new "iio: accel: bmc150: Fix bma222 scale unit" patch at the
> beginning so the stable people can backport it without conflicts
> - Add Reviewed-by: from Hans and Andy for all previous patches
> - Add patch 3 and 4 to have all the chip lists in a consistent order
> - Fix last patch to also drop BMA254 from the file header in bma180.c
>
> v1: https://lore.kernel.org/linux-iio/20210610095300.3613-1-stephan@gerhold.net/
>
> Stephan Gerhold (10):
> iio: accel: bmc150: Fix bma222 scale unit
> iio: accel: bmc150: Clarify combo modules in Kconfig
> iio: accel: bmc150: Drop misleading/duplicate chip identifiers
> iio: accel: bmc150: Drop duplicated documentation of supported chips
> iio: accel: bmc150: Sort all chip names alphabetically / by chip ID
> dt-bindings: iio: accel: bma255: Document bosch,bma253
> iio: accel: bmc150: Add device IDs for BMA253
> dt-bindings: iio: bma255: Allow multiple interrupts
> dt-bindings: iio: accel: bma180/bma255: Move bma254 to bma255 schema
> iio: accel: bma180/bmc150: Move BMA254 to bmc150-accel driver
>
> .../bindings/iio/accel/bosch,bma180.yaml | 3 +-
> .../bindings/iio/accel/bosch,bma255.yaml | 9 +-
> drivers/iio/accel/Kconfig | 11 ++-
> drivers/iio/accel/bma180.c | 92 +++----------------
> drivers/iio/accel/bmc150-accel-core.c | 87 ++++++------------
> drivers/iio/accel/bmc150-accel-i2c.c | 52 +++++------
> drivers/iio/accel/bmc150-accel-spi.c | 31 ++++---
> drivers/iio/accel/bmc150-accel.h | 10 --
> 8 files changed, 98 insertions(+), 197 deletions(-)
>
prev parent reply other threads:[~2021-06-11 17:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 8:08 [PATCH v3 00/10] iio: accel: bmc150: Add support for BMA253/BMA254 Stephan Gerhold
2021-06-11 8:08 ` [PATCH v3 01/10] iio: accel: bmc150: Fix bma222 scale unit Stephan Gerhold
2021-06-11 8:08 ` [PATCH v3 02/10] iio: accel: bmc150: Clarify combo modules in Kconfig Stephan Gerhold
2021-06-11 8:08 ` [PATCH v3 03/10] iio: accel: bmc150: Drop misleading/duplicate chip identifiers Stephan Gerhold
2021-06-11 8:08 ` [PATCH v3 04/10] iio: accel: bmc150: Drop duplicated documentation of supported chips Stephan Gerhold
2021-06-11 8:08 ` [PATCH v3 05/10] iio: accel: bmc150: Sort all chip names alphabetically / by chip ID Stephan Gerhold
2021-06-11 8:08 ` [PATCH v3 06/10] dt-bindings: iio: accel: bma255: Document bosch,bma253 Stephan Gerhold
2021-06-11 8:09 ` [PATCH v3 07/10] iio: accel: bmc150: Add device IDs for BMA253 Stephan Gerhold
2021-06-11 8:09 ` [PATCH v3 08/10] dt-bindings: iio: bma255: Allow multiple interrupts Stephan Gerhold
2021-06-11 17:59 ` Jonathan Cameron
2021-06-11 18:21 ` Stephan Gerhold
2021-06-11 18:26 ` Jonathan Cameron
2021-06-11 19:21 ` Stephan Gerhold
2021-06-11 8:09 ` [PATCH v3 09/10] dt-bindings: iio: accel: bma180/bma255: Move bma254 to bma255 schema Stephan Gerhold
2021-06-11 8:09 ` [PATCH v3 10/10] iio: accel: bma180/bmc150: Move BMA254 to bmc150-accel driver Stephan Gerhold
2021-06-11 17:35 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210611183537.40adbfed@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).