From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83CFFC07E95 for ; Tue, 13 Jul 2021 17:45:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63E0460720 for ; Tue, 13 Jul 2021 17:45:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229585AbhGMRsa (ORCPT ); Tue, 13 Jul 2021 13:48:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:55482 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229478AbhGMRsa (ORCPT ); Tue, 13 Jul 2021 13:48:30 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C4C0461358; Tue, 13 Jul 2021 17:45:36 +0000 (UTC) Date: Tue, 13 Jul 2021 18:47:54 +0100 From: Jonathan Cameron To: Sean Nyekjaer Cc: Lars-Peter Clausen , andy.shevchenko@gmail.com, kernel test robot , Dan Carpenter , Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] iio: accel: fxls8962af: fix potential use of uninitialized symbol Message-ID: <20210713184754.07d4d7c5@jic23-huawei> In-Reply-To: <20210709071727.2453536-1-sean@geanix.com> References: <20210709071727.2453536-1-sean@geanix.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Fri, 9 Jul 2021 09:17:27 +0200 Sean Nyekjaer wrote: > Fix this warning from kernel test robot: > smatch warnings: > drivers/iio/accel/fxls8962af-core.c:640 > fxls8962af_i2c_raw_read_errata3() error: uninitialized symbol 'ret'. > > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-off-by: Sean Nyekjaer > Fixes: af959b7b96b8 ("iio: accel: fxls8962af: fix errata bug E3 - I2C burst reads") Applied to the fixes-togreg branch of iio.git Thanks, Jonathan > --- > Changes since v2: > - add commit msg > > drivers/iio/accel/fxls8962af-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/accel/fxls8962af-core.c b/drivers/iio/accel/fxls8962af-core.c > index 078d87865fde..0019f1ea7df2 100644 > --- a/drivers/iio/accel/fxls8962af-core.c > +++ b/drivers/iio/accel/fxls8962af-core.c > @@ -637,7 +637,7 @@ static int fxls8962af_i2c_raw_read_errata3(struct fxls8962af_data *data, > return ret; > } > > - return ret; > + return 0; > } > > static int fxls8962af_fifo_transfer(struct fxls8962af_data *data,