From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DBB0C636CA for ; Sun, 18 Jul 2021 14:42:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 38A6461183 for ; Sun, 18 Jul 2021 14:42:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233993AbhGROpP (ORCPT ); Sun, 18 Jul 2021 10:45:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:52572 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233958AbhGROpP (ORCPT ); Sun, 18 Jul 2021 10:45:15 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F0EC66108B; Sun, 18 Jul 2021 14:42:14 +0000 (UTC) Date: Sun, 18 Jul 2021 15:44:39 +0100 From: Jonathan Cameron To: Colin King Cc: Lars-Peter Clausen , linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: light: si1145: remove redundant continue statement Message-ID: <20210718154439.32d89fa4@jic23-huawei> In-Reply-To: <20210617081312.151746-1-colin.king@canonical.com> References: <20210617081312.151746-1-colin.king@canonical.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Thu, 17 Jun 2021 09:13:12 +0100 Colin King wrote: > From: Colin Ian King > > The continue statement at the end of a for-loop has no effect, > remove it. > > Addresses-Coverity: ("Continue has no effect") > Signed-off-by: Colin Ian King Applied. Thanks, Jonathan > --- > drivers/iio/light/si1145.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/iio/light/si1145.c b/drivers/iio/light/si1145.c > index e2abad48b9f4..e8f6cdf26f22 100644 > --- a/drivers/iio/light/si1145.c > +++ b/drivers/iio/light/si1145.c > @@ -220,7 +220,6 @@ static int __si1145_command_reset(struct si1145_data *data) > return -ETIMEDOUT; > } > msleep(SI1145_COMMAND_MINSLEEP_MS); > - continue; > } > } >