From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F69FC636C8 for ; Sun, 18 Jul 2021 14:49:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1330D610A5 for ; Sun, 18 Jul 2021 14:49:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233931AbhGROw2 (ORCPT ); Sun, 18 Jul 2021 10:52:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:53560 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233869AbhGROw1 (ORCPT ); Sun, 18 Jul 2021 10:52:27 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0986E61001; Sun, 18 Jul 2021 14:49:27 +0000 (UTC) Date: Sun, 18 Jul 2021 15:51:52 +0100 From: Jonathan Cameron To: Chris Lesiak Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Matt Ranostay Subject: Re: [PATCH v3] iio: humidity: hdc100x: Add margin to the conversion time Message-ID: <20210718155152.66f791bc@jic23-huawei> In-Reply-To: <20210616134335.76715e55@jic23-huawei> References: <20210614141820.2034827-1-chris.lesiak@licor.com> <20210616134335.76715e55@jic23-huawei> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, 16 Jun 2021 13:43:35 +0100 Jonathan Cameron wrote: > On Mon, 14 Jun 2021 09:18:20 -0500 > Chris Lesiak wrote: > > > The datasheets have the following note for the conversion time > > specification: "This parameter is specified by design and/or > > characterization and it is not tested in production." > > > > Parts have been seen that require more time to do 14-bit conversions for > > the relative humidity channel. The result is ENXIO due to the address > > phase of a transfer not getting an ACK. > > > > Delay an additional 1 ms per conversion to allow for additional margin. > > > > Fixes: 4839367d99e3 ("iio: humidity: add HDC100x support") > > Signed-off-by: Chris Lesiak > > +CC Matt as this is one of his drivers. @Matt. Ping. > > Looks good to me. > > > --- > > drivers/iio/humidity/hdc100x.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c > > index 2a957f19048e..9e0fce917ce4 100644 > > --- a/drivers/iio/humidity/hdc100x.c > > +++ b/drivers/iio/humidity/hdc100x.c > > @@ -25,6 +25,8 @@ > > #include > > #include > > > > +#include > > + > > #define HDC100X_REG_TEMP 0x00 > > #define HDC100X_REG_HUMIDITY 0x01 > > > > @@ -166,7 +168,7 @@ static int hdc100x_get_measurement(struct hdc100x_data *data, > > struct iio_chan_spec const *chan) > > { > > struct i2c_client *client = data->client; > > - int delay = data->adc_int_us[chan->address]; > > + int delay = data->adc_int_us[chan->address] + 1*USEC_PER_MSEC; > > int ret; > > __be16 val; > > > > @@ -316,7 +318,7 @@ static irqreturn_t hdc100x_trigger_handler(int irq, void *p) > > struct iio_dev *indio_dev = pf->indio_dev; > > struct hdc100x_data *data = iio_priv(indio_dev); > > struct i2c_client *client = data->client; > > - int delay = data->adc_int_us[0] + data->adc_int_us[1]; > > + int delay = data->adc_int_us[0] + data->adc_int_us[1] + 2*USEC_PER_MSEC; > > int ret; > > > > /* dual read starts at temp register */ >