From: Jonathan Cameron <jic23@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-iio <linux-iio@vger.kernel.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Denis Ciocca <denis.ciocca@st.com>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH] iio: st-sensors: Remove some unused includes and add some that should be there
Date: Sun, 18 Jul 2021 16:09:54 +0100 [thread overview]
Message-ID: <20210718160954.037c49fc@jic23-huawei> (raw)
In-Reply-To: <CACRpkdYmToL445kE5A53+sRitFxsn5e7sn+PPiQiPv1OocDopA@mail.gmail.com>
On Wed, 9 Jun 2021 09:53:57 +0200
Linus Walleij <linus.walleij@linaro.org> wrote:
> On Tue, Jun 8, 2021 at 7:50 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > The st-sensors drivers have changed in structure over time, and includes
> > have not always kept up with this. Let's bring them back to nearer
> > the ideal.
> >
> > Identified with the include-what-you-use tool and careful checking of
> > its suggestions.
> >
> > Note I haven't been particularly aggressive here, so this is just the
> > cases where the include obviously isn't needed rather than the more
> > subtle corners.
> >
> > Note I took the opportunity to add mod_devicetable.h as I generally
> > prefer to see that when acpi or of match tables are present.
> >
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Cc: Denis Ciocca <denis.ciocca@st.com>
> > Cc: Hans de Goede <hdegoede@redhat.com>
>
> Looks good to me.
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> Yours,
> Linus Walleij
This seems unaffected by the questions around kernel.h and the
splitting that Andy is working on for that. Hence applied to the togreg
branch of iio.git and pushed out as testing to see if 0-day can find
anything I missed.
Thanks,
Jonathan
prev parent reply other threads:[~2021-07-18 15:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 17:51 [PATCH] iio: st-sensors: Remove some unused includes and add some that should be there Jonathan Cameron
2021-06-09 7:53 ` Linus Walleij
2021-07-18 15:09 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210718160954.037c49fc@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=denis.ciocca@st.com \
--cc=hdegoede@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).