From: Jonathan Cameron <jic23@kernel.org>
To: Mihail Chindris <mihail.chindris@analog.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
<lars@metafoo.de>, <Michael.Hennerich@analog.com>,
<nuno.sa@analog.com>, <dragos.bogdan@analog.com>,
<alexandru.ardelean@analog.com>
Subject: Re: [PATCH v4 4/6] Documentation:ABI:testing:add doc for AD3552R ABI
Date: Mon, 30 Aug 2021 16:22:03 +0100 [thread overview]
Message-ID: <20210830162203.6f40790c@jic23-huawei> (raw)
In-Reply-To: <20210820165927.4524-5-mihail.chindris@analog.com>
On Fri, 20 Aug 2021 16:59:25 +0000
Mihail Chindris <mihail.chindris@analog.com> wrote:
> Add documentation for option for enabling precision mode
> of ad3552r
>
> Signed-off-by: Mihail Chindris <mihail.chindris@analog.com>
> ---
> Documentation/ABI/testing/sysfs-bus-iio-dac-ad3552r | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-dac-ad3552r
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio-dac-ad3552r b/Documentation/ABI/testing/sysfs-bus-iio-dac-ad3552r
> new file mode 100644
> index 000000000000..37573245f3d5
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-bus-iio-dac-ad3552r
> @@ -0,0 +1,10 @@
> +What: /sys/bus/iio/devices/iio:deviceX/precision_mode_en
> +KernelVersion: 5.13
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Select between fast mode and precison mode.
> + 0: Fast mode - For 12 bits precision, the most significant
> + bits are used and 16 bits are sent to the
> + device per channel, lats bits being 0.
least significant bits being 0
perhaps and definitely not lats bits :)
> + 1: Precision mode - For 16 bits precision, 24 bits are sent to
> + the device per channel, last bits being 0.
I don't think the ABI cares about how many bits are sent, but rather it cares
about the precision.
I'm not keen on this ABI if we can possibly avoid it. It is highly device specific
and therefore unlikely to ever get used by any standard userspace code.
Given I'm fairly sure no linux host is ever going to get anywhere near the maximum
rates this device supports, perhaps we should just always use precision mode and
not worry about this detail?
Jonathan
next prev parent reply other threads:[~2021-08-30 15:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 16:59 [PATCH v4 0/6] iio: Add output buffer support and DAC example Mihail Chindris
2021-08-20 16:59 ` [PATCH v4 1/6] iio: Add output buffer support Mihail Chindris
2021-08-21 0:24 ` kernel test robot
2021-08-23 2:23 ` kernel test robot
2021-08-23 13:50 ` Nuno Sá
2021-08-30 15:42 ` Jonathan Cameron
2021-09-01 8:50 ` Sa, Nuno
2021-09-05 9:54 ` Jonathan Cameron
2021-08-25 8:35 ` Alexandru Ardelean
2021-08-30 16:05 ` Jonathan Cameron
2021-09-01 8:54 ` Sa, Nuno
2021-09-05 9:55 ` Jonathan Cameron
2021-09-16 10:57 ` Chindris, Mihail
2021-08-20 16:59 ` [PATCH v4 2/6] iio: kfifo-buffer: " Mihail Chindris
2021-08-21 14:15 ` kernel test robot
2021-08-23 13:51 ` Nuno Sá
2021-08-20 16:59 ` [PATCH v4 3/6] iio: triggered-buffer: extend support to configure output buffers Mihail Chindris
2021-08-21 3:28 ` kernel test robot
2021-08-20 16:59 ` [PATCH v4 4/6] Documentation:ABI:testing:add doc for AD3552R ABI Mihail Chindris
2021-08-30 15:22 ` Jonathan Cameron [this message]
2021-08-20 16:59 ` [PATCH v4 5/6] dt-bindings: iio: dac: Add adi,ad3552r.yaml Mihail Chindris
2021-08-30 15:37 ` Jonathan Cameron
2021-08-20 16:59 ` [PATCH v4 6/6] drivers:iio:dac: Add AD3552R driver support Mihail Chindris
2021-08-20 19:55 ` kernel test robot
2021-08-20 22:15 ` kernel test robot
2021-08-23 14:01 ` Nuno Sá
2021-08-30 16:54 ` Jonathan Cameron
2021-08-25 7:35 ` [PATCH v4 0/6] iio: Add output buffer support and DAC example Alexandru Ardelean
2021-08-30 15:17 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210830162203.6f40790c@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.ardelean@analog.com \
--cc=dragos.bogdan@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mihail.chindris@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox