From: Jonathan Cameron <jic23@kernel.org>
To: "Sa, Nuno" <Nuno.Sa@analog.com>
Cc: "Chindris, Mihail" <Mihail.Chindris@analog.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
"Bogdan, Dragos" <Dragos.Bogdan@analog.com>
Subject: Re: [PATCH v4 1/6] iio: Add output buffer support
Date: Sun, 5 Sep 2021 10:55:18 +0100 [thread overview]
Message-ID: <20210905105518.56fde2d4@jic23-huawei> (raw)
In-Reply-To: <MW4PR03MB636324E990C3ED6BF8D6D94399CD9@MW4PR03MB6363.namprd03.prod.outlook.com>
> > > + if (test_bit(IIO_BUSY_BIT_POS, &rb->flags))
> > > + return -EBUSY;
> > > +
> > > + return iio_buffer_write(filp, buf, n, f_ps);
> > > +}
> > > +
> > > __poll_t iio_buffer_poll_wrapper(struct file *filp,
> > > struct poll_table_struct *wait)
> > > {
> > > @@ -231,6 +317,15 @@ void iio_buffer_wakeup_poll(struct iio_dev
> > *indio_dev)
> > > }
> > > }
> > >
> > > +int iio_buffer_remove_sample(struct iio_buffer *buffer, u8 *data)
> >
> > sample or scan? Sample would be a single value for a single channel,
> > scan would be updates for all channels that are enabled.
>
> Maybe iio_pop_from_buffer()? To be consistent with iio_push_to_buffer()..
Works for me.
J
>
> - Nuno Sá
next prev parent reply other threads:[~2021-09-05 9:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 16:59 [PATCH v4 0/6] iio: Add output buffer support and DAC example Mihail Chindris
2021-08-20 16:59 ` [PATCH v4 1/6] iio: Add output buffer support Mihail Chindris
2021-08-21 0:24 ` kernel test robot
2021-08-23 2:23 ` kernel test robot
2021-08-23 13:50 ` Nuno Sá
2021-08-30 15:42 ` Jonathan Cameron
2021-09-01 8:50 ` Sa, Nuno
2021-09-05 9:54 ` Jonathan Cameron
2021-08-25 8:35 ` Alexandru Ardelean
2021-08-30 16:05 ` Jonathan Cameron
2021-09-01 8:54 ` Sa, Nuno
2021-09-05 9:55 ` Jonathan Cameron [this message]
2021-09-16 10:57 ` Chindris, Mihail
2021-08-20 16:59 ` [PATCH v4 2/6] iio: kfifo-buffer: " Mihail Chindris
2021-08-21 14:15 ` kernel test robot
2021-08-23 13:51 ` Nuno Sá
2021-08-20 16:59 ` [PATCH v4 3/6] iio: triggered-buffer: extend support to configure output buffers Mihail Chindris
2021-08-21 3:28 ` kernel test robot
2021-08-20 16:59 ` [PATCH v4 4/6] Documentation:ABI:testing:add doc for AD3552R ABI Mihail Chindris
2021-08-30 15:22 ` Jonathan Cameron
2021-08-20 16:59 ` [PATCH v4 5/6] dt-bindings: iio: dac: Add adi,ad3552r.yaml Mihail Chindris
2021-08-30 15:37 ` Jonathan Cameron
2021-08-20 16:59 ` [PATCH v4 6/6] drivers:iio:dac: Add AD3552R driver support Mihail Chindris
2021-08-20 19:55 ` kernel test robot
2021-08-20 22:15 ` kernel test robot
2021-08-23 14:01 ` Nuno Sá
2021-08-30 16:54 ` Jonathan Cameron
2021-08-25 7:35 ` [PATCH v4 0/6] iio: Add output buffer support and DAC example Alexandru Ardelean
2021-08-30 15:17 ` Jonathan Cameron
[not found] <202108222341.6RtluiRt-lkp@intel.com>
2021-08-25 15:31 ` [PATCH v4 1/6] iio: Add output buffer support kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210905105518.56fde2d4@jic23-huawei \
--to=jic23@kernel.org \
--cc=Dragos.Bogdan@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=Mihail.Chindris@analog.com \
--cc=Nuno.Sa@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).