From: Florian Boor <florian.boor@kernelconcepts.de>
To: jic23@kernel.org
Cc: linux-iio@vger.kernel.org, Jonathan.Cameron@huawei.com,
Michael.Hennerich@analog.com,
Florian Boor <florian.boor@kernelconcepts.de>
Subject: [PATCH v2 1/2] iio: adc: ad799x: Implement selecting external reference voltage input on AD7991, AD7995 and AD7999.
Date: Wed, 8 Sep 2021 17:25:24 +0200 [thread overview]
Message-ID: <20210908152525.2946785-1-florian.boor@kernelconcepts.de> (raw)
Make use of the AD7991_REF_SEL bit and support using the external
reference voltage if 'vref-supply' is present.
Signed-off-by: Florian Boor <florian.boor@kernelconcepts.de>
---
Changes in v2:
- Check if a provided external vref regulator is provided.
- Drop unused setting
- Add ad79xx documentation (second patch)
drivers/iio/adc/ad799x.c | 21 +++++++++++++++++++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/ad799x.c b/drivers/iio/adc/ad799x.c
index 18bf8386d50a..2ff926a4e9b3 100644
--- a/drivers/iio/adc/ad799x.c
+++ b/drivers/iio/adc/ad799x.c
@@ -770,6 +770,8 @@ static int ad799x_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
int ret;
+ int extra_config = 0;
+ bool vref_external = true;
struct ad799x_state *st;
struct iio_dev *indio_dev;
const struct ad799x_chip_info *chip_info =
@@ -797,7 +799,15 @@ static int ad799x_probe(struct i2c_client *client,
ret = regulator_enable(st->reg);
if (ret)
return ret;
- st->vref = devm_regulator_get(&client->dev, "vref");
+
+ /* check if an external reference is supplied */
+ st->vref = devm_regulator_get_optional(&client->dev, "vref");
+
+ if (PTR_ERR(st->vref) == -ENODEV) {
+ vref_external = false;
+ /* get dummy */
+ st->vref = devm_regulator_get(&client->dev, "vref");
+ }
if (IS_ERR(st->vref)) {
ret = PTR_ERR(st->vref);
goto error_disable_reg;
@@ -806,6 +816,13 @@ static int ad799x_probe(struct i2c_client *client,
if (ret)
goto error_disable_reg;
+ /* use external reference voltage, optional if regulator present */
+ if (vref_external &&
+ ((st->id == ad7991) || (st->id == ad7995) || (st->id == ad7999))) {
+ dev_info(&client->dev, "Using external reference voltage\n");
+ extra_config |= AD7991_REF_SEL;
+ }
+
st->client = client;
indio_dev->name = id->name;
@@ -815,7 +832,7 @@ static int ad799x_probe(struct i2c_client *client,
indio_dev->channels = st->chip_config->channel;
indio_dev->num_channels = chip_info->num_channels;
- ret = ad799x_update_config(st, st->chip_config->default_config);
+ ret = ad799x_update_config(st, st->chip_config->default_config | extra_config);
if (ret)
goto error_disable_vref;
--
2.30.2
next reply other threads:[~2021-09-08 15:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 15:25 Florian Boor [this message]
2021-09-08 15:25 ` [PATCH v2 2/2] dt-binding: iio: Add documentation for AD799x driver Florian Boor
2021-09-11 16:34 ` Jonathan Cameron
2021-09-11 16:43 ` [PATCH v2 1/2] iio: adc: ad799x: Implement selecting external reference voltage input on AD7991, AD7995 and AD7999 Jonathan Cameron
2021-09-14 13:21 ` Florian Boor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210908152525.2946785-1-florian.boor@kernelconcepts.de \
--to=florian.boor@kernelconcepts.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).