From: Tim Gardner <tim.gardner@canonical.com>
To: linux-iio@vger.kernel.org
Cc: tim.gardner@canonical.com,
William Breathitt Gray <vilhelm.gray@gmail.com>,
Syed Nayyar Waris <syednwaris@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2][next] counter: Add default statement to switch() in quad8_function_read()
Date: Mon, 20 Sep 2021 11:37:37 -0600 [thread overview]
Message-ID: <20210920173737.21445-1-tim.gardner@canonical.com> (raw)
v2: Add the correct Cc's
Coverity complains of a possible use of an uninitialized variable
in quad8_action_read().
CID 119643 (#1 of 1): Uninitialized scalar variable (UNINIT)
4. uninit_use: Using uninitialized value function.
346 switch (function) {
The call to quad8_function_read() could theoretically return without
assigning a value to '*function', thus causing the use of an
ininitialized variable 'function' in quad8_action_read().
Fix this by adding a default statement to the switch in
quad8_function_read() and returning an error.
Cc: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: Syed Nayyar Waris <syednwaris@gmail.com>
Cc: linux-iio@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
drivers/counter/104-quad-8.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c
index c587f295d720..3a69d35b82ea 100644
--- a/drivers/counter/104-quad-8.c
+++ b/drivers/counter/104-quad-8.c
@@ -215,6 +215,8 @@ static int quad8_function_read(struct counter_device *counter,
case 2:
*function = COUNTER_FUNCTION_QUADRATURE_X4;
break;
+ default:
+ return -1;
}
else
*function = COUNTER_FUNCTION_PULSE_DIRECTION;
--
2.33.0
next reply other threads:[~2021-09-20 17:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 17:37 Tim Gardner [this message]
2021-09-21 0:36 ` [PATCH v2][next] counter: Add default statement to switch() in quad8_function_read() William Breathitt Gray
2021-09-21 13:37 ` [PATCH v3][next] " Tim Gardner
2021-09-21 22:51 ` William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210920173737.21445-1-tim.gardner@canonical.com \
--to=tim.gardner@canonical.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syednwaris@gmail.com \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox