Re: [PATCH 1/4] dt-bindings: iio: adc: sd modulator: add vref support

Olivier MOYSAN
2020-02-11T15:24:41Z

On 2/8/20 5:04 PM, Jonathan Cameron wrote:
> On Tue, 4 Feb 2020 11:10:05 +0100
> Olivier Moysan <olivier.moysan@st.com> wrote:
>
>> Add vref supply support to sigma delta modulator.
>>
>> Signed-off-by: Olivier Moysan <olivier.moysan@st.com>
>> ---
>> .../devicetree/bindings/iio/adc/sigma-delta-modulator.yaml | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml
>> index a390343d0c2a..2afe0765e971 100644
>> --- a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml
>> +++ b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml
>> @@ -8,6 +8,7 @@ title: Device-Tree bindings for sigma delta modulator
>>
>> maintainers:
>> - Arnaud Pouliquen <arnaud.pouliquen@st.com>
>> + - Olivier Moysan <olivier.moysan@st.com>
>>
>> properties:
>> compatible:
>> @@ -21,6 +22,9 @@ properties:
>> '#io-channel-cells':
>> const: 0
>>
>> + vref-supply:
>> + description: Phandle to the vref input analog reference voltage.
> I note this in review of patch 2 but in general I'm not sure we should
> be introducing this for generic devices. It's fine if we have an
> explicit compatible but there is no reason to assume a generic sd-modulator
> uses an external reference.
>
> Jonathan
Ok, I will remove reference to external voltage for generic
sd-modulator, in v2.
I will add it for ads1201 compatible, instead.

Thanks for your review
Olivier
>> +
>> required:
>> - compatible
>> - '#io-channel-cells'