From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Maxim Levitsky <maximlevitsky@gmail.com>,
linux-iio <linux-iio@vger.kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: BMI160 accelerometer on AyaNeo tablet
Date: Mon, 18 Oct 2021 16:17:32 +0100 [thread overview]
Message-ID: <20211018161732.0000565f@Huawei.com> (raw)
In-Reply-To: <CAHp75Vct-AXnU7QQmdE7nyYZT-=n=p67COPLiiZTet7z7snL-g@mail.gmail.com>
On Mon, 18 Oct 2021 10:40:33 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> +Cc: Hans
>
> On Mon, Oct 18, 2021 at 6:41 AM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > On Sat, 16 Oct 2021 19:27:50 +0300
> > Maxim Levitsky <maximlevitsky@gmail.com> wrote:
> >
> > > BMI160: AYA NEA accelometer ID
>
> accelerometer
>
> > > On AYA NEO, the accelerometer is BMI160 but it is exposed
> > > via ACPI as 10EC5280
> > >
> > > Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
> >
> > I guess it is hopelessly optimistic to hope that we could let someone
> > at the supplier know that's a totally invalid ACPI id and that they
> > should clean up their act.
> >
> > Curiously it looks like a valid PCI ID pair though for a realtek device.
> >
> > Ah well. Applied to the iio-togreg branch of iio.git and pushed out
> > as testing to see if 0-day can find any issues with it.
>
> NAK. And I explain below why and how to make progress with it.
>
> The commit message should contain at least the link to the DSDT and
> official technical description of the platform. Besides that, it
> should have a corresponding comment near to the ID in the code.
>
> On top of that, in particular to this case, the ID is very valid from
> the ACPI specification point of view, but in this case it's a
> representation of the PCI ID 10ec:5280 which is Realtek owned. So, we
> need to hear (okay in reasonable time) from Realtek (I believe they
> are active in the Linux kernel) and that OEM.
>
> I hardly believe that Realtek has issued a special ID from the range
> where mostly PCIe ports or so are allocated, although it's possible.
> We need proof.
>
> What I believe is the case here is that OEMs are just quite diletants
> in ACPI and firmware and they messed up with BIOS somehow that it
> issued the ID for the device.
> There are also two other possibilities: OEM stole the ID (deliberately
> or accidentally), or the device is not just gyro, but something which
> contains gyro.
>
> As to the last paragraph, see above, we must see DSDT. Without it I
> have a strong NAK.
>
> P.S. Jonathan, please do not be so fast next time with ACPI IDs.
No problem. Will pull this one once I'm back on correct PC.
Jonathan
>
next prev parent reply other threads:[~2021-10-18 15:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CACAwPwb7edLzX-KO1XVNWuQ3w=U0BfA=_kwiGCjZOpKfZpc2pw@mail.gmail.com>
2021-10-16 16:27 ` BMI160 accelerometer on AyaNeo tablet Maxim Levitsky
2021-10-17 10:58 ` Jonathan Cameron
2021-10-18 7:40 ` Andy Shevchenko
2021-10-18 15:17 ` Jonathan Cameron [this message]
2021-10-18 15:22 ` Andy Shevchenko
2021-10-18 15:30 ` Andy Shevchenko
2021-10-18 18:02 ` Maxim Levitsky
2021-10-18 19:02 ` Andy Shevchenko
2021-10-18 20:42 ` Maxim Levitsky
2021-10-19 9:58 ` Andy Shevchenko
2021-10-19 16:29 ` Maxim Levitsky
2021-10-20 2:31 ` Hayes Wang
[not found] ` <CAHp75VfB2FULb_jfQNg0wF9Z4jPkrKfmw6hSwtLg8Y1NhKks8g@mail.gmail.com>
2021-10-20 11:21 ` Andy Shevchenko
2021-11-16 17:49 ` Andy Shevchenko
2022-01-19 19:05 ` Maxim Levitsky
2022-01-19 20:51 ` Andy Shevchenko
2022-01-23 17:22 ` Maxim Levitsky
2022-02-02 16:23 ` Andy Shevchenko
2021-10-20 17:37 ` Jonathan Cameron
2021-10-20 20:03 ` Andy Shevchenko
2021-10-19 8:10 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211018161732.0000565f@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).