From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: Mark iio_device_type as const
Date: Wed, 3 Nov 2021 17:51:46 +0000 [thread overview]
Message-ID: <20211103175146.159f5d3f@jic23-huawei> (raw)
In-Reply-To: <20211031080421.2086-1-lars@metafoo.de>
On Sun, 31 Oct 2021 09:04:21 +0100
Lars-Peter Clausen <lars@metafoo.de> wrote:
> The iio_device_type struct is never modified, mark it as const. This allows
> it to be placed in a read-only memory section, which will protect against
> accidental or deliberate modification.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the togreg branch of iio.git which will be only visible
as testing for 0-day to poke at it until after the merge window.
Thanks,
Jonathan
> ---
> drivers/iio/iio_core.h | 2 +-
> drivers/iio/industrialio-core.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/iio_core.h b/drivers/iio/iio_core.h
> index 61e318431de9..501e286702ef 100644
> --- a/drivers/iio/iio_core.h
> +++ b/drivers/iio/iio_core.h
> @@ -16,7 +16,7 @@ struct iio_buffer;
> struct iio_chan_spec;
> struct iio_dev;
>
> -extern struct device_type iio_device_type;
> +extern const struct device_type iio_device_type;
>
> struct iio_dev_buffer_pair {
> struct iio_dev *indio_dev;
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index 463a63d5bf56..737518efa38f 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -1619,7 +1619,7 @@ static void iio_dev_release(struct device *device)
> kfree(iio_dev_opaque);
> }
>
> -struct device_type iio_device_type = {
> +const struct device_type iio_device_type = {
> .name = "iio_device",
> .release = iio_dev_release,
> };
prev parent reply other threads:[~2021-11-03 17:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-31 8:04 [PATCH] iio: Mark iio_device_type as const Lars-Peter Clausen
2021-11-03 17:51 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211103175146.159f5d3f@jic23-huawei \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox