From: Jonathan Cameron <jic23@kernel.org>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: lars@metafoo.de, andy.shevchenko@gmail.com, linux-iio@vger.kernel.org
Subject: Re: [PATCH 3/4] iio: xilinx-xadc-core: Use local variable in xadc_read_raw
Date: Wed, 3 Nov 2021 18:55:00 +0000 [thread overview]
Message-ID: <20211103185500.4835cbc2@jic23-huawei> (raw)
In-Reply-To: <20211101071822.522178-4-gwendal@chromium.org>
On Mon, 1 Nov 2021 00:18:21 -0700
Gwendal Grignou <gwendal@chromium.org> wrote:
> Minor cleanup: bit is already defined as chan->scan_type.realbits,
> use bit when needed.
>
bits
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Otherwise looks good to me.
> ---
> drivers/iio/adc/xilinx-xadc-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
> index 83bea5ef765da..05050709e4f8a 100644
> --- a/drivers/iio/adc/xilinx-xadc-core.c
> +++ b/drivers/iio/adc/xilinx-xadc-core.c
> @@ -943,7 +943,7 @@ static int xadc_read_raw(struct iio_dev *indio_dev,
> *val = 1000;
> break;
> }
> - *val2 = chan->scan_type.realbits;
> + *val2 = bits;
> return IIO_VAL_FRACTIONAL_LOG2;
> case IIO_TEMP:
> /* Temp in C = (val * 503.975) / 2**bits - 273.15 */
next prev parent reply other threads:[~2021-11-03 18:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 7:18 [PATCH 0/4] iio: Use scan_type shift and realbits when processing raw data Gwendal Grignou
2021-11-01 7:18 ` [PATCH 1/4] " Gwendal Grignou
2021-11-03 18:42 ` Jonathan Cameron
2021-11-04 8:24 ` Gwendal Grignou
2021-11-04 8:49 ` Eugen.Hristev
2021-11-01 7:18 ` [PATCH 2/4] iio: ti-ads1015: Remove shift variable ads1015_read_raw Gwendal Grignou
2021-11-03 18:53 ` Jonathan Cameron
2021-11-01 7:18 ` [PATCH 3/4] iio: xilinx-xadc-core: Use local variable in xadc_read_raw Gwendal Grignou
2021-11-03 18:55 ` Jonathan Cameron [this message]
2021-11-01 7:18 ` [PATCH 4/4] iio: mpl3115: Use scan_type.shift and realbit in mpl3115_read_raw Gwendal Grignou
2021-11-03 18:58 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211103185500.4835cbc2@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=gwendal@chromium.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox