Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Cai Huoqing <caihuoqing@baidu.com>,
	linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: imx8qxp-adc: fix dependency to the intended ARCH_MXC config
Date: Fri, 12 Nov 2021 16:20:13 +0000	[thread overview]
Message-ID: <20211112162013.01f4f171@jic23-huawei> (raw)
In-Reply-To: <CAOMZO5B4k=UvE5XTgbsjCfoo0h0Y7H+xN6mwh9Bnc2L82QYzwQ@mail.gmail.com>

On Thu, 11 Nov 2021 07:31:25 -0300
Fabio Estevam <festevam@gmail.com> wrote:

> Hi Lukas,
> 
> On Thu, Nov 11, 2021 at 5:40 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> >
> > Commit 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP
> > ADC") adds the config IMX8QXP_ADC for this new driver, which depends on
> > the non-existing config ARCH_MXC_ARM64.
> >
> > Hence, ./scripts/checkkconfigsymbols.py warns:
> >
> >   ARCH_MXC_ARM64
> >   Referencing files: drivers/iio/adc/Kconfig
> >
> > Probably, the existing config ARCH_MXC is intended to be referred here.
> > So, repair the dependency to refer to that config.
> >
> > Fixes: 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC")
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>  
> 
> This looks good.
> 
> The incorrect  ARCH_MXC_ARM64 symbol probably came when porting the
> driver from the NXP downstream kernel:
> 
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Applied to the fixes-togreg branch of iio.git

Thanks,

Jonathan



      reply	other threads:[~2021-11-12 16:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11  8:39 [PATCH] iio: imx8qxp-adc: fix dependency to the intended ARCH_MXC config Lukas Bulwahn
2021-11-11 10:31 ` Fabio Estevam
2021-11-12 16:20   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211112162013.01f4f171@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=caihuoqing@baidu.com \
    --cc=festevam@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox