Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: lars@metafoo.de, andy.shevchenko@gmail.com, linux-iio@vger.kernel.org
Subject: Re: [PATCH v2 00/13] iio: Use scan_type shift and realbits when processing raw data
Date: Sat, 13 Nov 2021 16:43:36 +0000	[thread overview]
Message-ID: <20211113164336.57f27801@jic23-huawei> (raw)
In-Reply-To: <20211104082413.3681212-1-gwendal@chromium.org>

On Thu,  4 Nov 2021 01:24:00 -0700
Gwendal Grignou <gwendal@chromium.org> wrote:

> Using scan_type has source of truth, use shift and realbits instead of
> constants when processing reading sensor registers to produce raw sysfs
> entries.
> The same shit and realbits are already used by the libiio user-space
> library to present channel information from device buffer.
> 
> Fix only a handful of drivers, where channel scan_type was accessible
> in the function handling the raw data request.
> 
> In mpl3115, use a 16 bit big endian buffer when reading temperature
> channel to improve readability.

All but patch 8 applied.  There are outstanding questions about how to
handle that one as it happens to also be fixing a bug.

Applied to the togreg branch of iio.git and pushed out as testing until
the merge window is over and I can rebase on rc1.

Thanks,

Jonathan

> 
> Changes in v2:
> - Split first CL, one CL for each driver
> - Add realbit for sca3000 temperature channel
> - Remove constant in bma220 driver.
> 
> Gwendal Grignou (13):
>   iio: bma220: Use scan_type when processing raw data
>   iio: kxcjk-1013: Use scan_type when processing raw data
>   iio: mma7455: Use scan_type when processing raw data
>   iio: sca3000: Use scan_type when processing raw data
>   iio: stk8312: Use scan_type when processing raw data
>   iio: stk8ba50: Use scan_type when processing raw data
>   iio: ad7266: Use scan_type when processing raw data
>   iio: at91-sama5d2: Use scan_type when processing raw data
>   iio: ti-adc12138: Use scan_type when processing raw data
>   iio: mag3110: Use scan_type when processing raw data
>   iio: ti-ads1015: Remove shift variable ads1015_read_raw
>   iio: xilinx-xadc-core: Use local variable in xadc_read_raw
>   iio: mpl3115: Use scan_type.shift and realbit in mpl3115_read_raw
> 
>  drivers/iio/accel/bma220_spi.c     |  6 +++---
>  drivers/iio/accel/kxcjk-1013.c     |  3 ++-
>  drivers/iio/accel/mma7455_core.c   |  3 ++-
>  drivers/iio/accel/sca3000.c        | 17 +++++++++++++----
>  drivers/iio/accel/stk8312.c        |  2 +-
>  drivers/iio/accel/stk8ba50.c       |  3 ++-
>  drivers/iio/adc/ad7266.c           |  3 ++-
>  drivers/iio/adc/at91-sama5d2_adc.c |  3 ++-
>  drivers/iio/adc/ti-adc12138.c      |  3 ++-
>  drivers/iio/adc/ti-ads1015.c       |  8 +++-----
>  drivers/iio/adc/xilinx-xadc-core.c |  2 +-
>  drivers/iio/magnetometer/mag3110.c |  6 ++++--
>  drivers/iio/pressure/mpl3115.c     | 16 +++++++++++-----
>  13 files changed, 48 insertions(+), 27 deletions(-)
> 


      parent reply	other threads:[~2021-11-13 16:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04  8:24 [PATCH v2 00/13] iio: Use scan_type shift and realbits when processing raw data Gwendal Grignou
2021-11-04  8:24 ` [PATCH v2 01/13] iio: bma220: Use scan_type " Gwendal Grignou
2021-11-04  8:24 ` [PATCH v2 02/13] iio: kxcjk-1013: " Gwendal Grignou
2021-11-04  8:24 ` [PATCH v2 03/13] iio: mma7455: " Gwendal Grignou
2021-11-04  8:24 ` [PATCH v2 04/13] iio: sca3000: " Gwendal Grignou
2021-11-04  8:24 ` [PATCH v2 05/13] iio: stk8312: " Gwendal Grignou
2021-11-04  8:24 ` [PATCH v2 06/13] iio: stk8ba50: " Gwendal Grignou
2021-11-04  8:24 ` [PATCH v2 07/13] iio: ad7266: " Gwendal Grignou
2021-11-04  8:24 ` [PATCH v2 08/13] iio: at91-sama5d2: " Gwendal Grignou
2021-11-13 16:42   ` Jonathan Cameron
2021-11-15  9:22     ` Eugen.Hristev
2021-11-21 13:45       ` Jonathan Cameron
2021-11-04  8:24 ` [PATCH v2 09/13] iio: ti-adc12138: " Gwendal Grignou
2021-11-04  8:24 ` [PATCH v2 10/13] iio: mag3110: " Gwendal Grignou
2021-11-04  8:24 ` [PATCH v2 11/13] iio: ti-ads1015: Remove shift variable ads1015_read_raw Gwendal Grignou
2021-11-04  8:24 ` [PATCH v2 12/13] iio: xilinx-xadc-core: Use local variable in xadc_read_raw Gwendal Grignou
2021-11-04  8:24 ` [PATCH v2 13/13] iio: mpl3115: Use scan_type.shift and realbit in mpl3115_read_raw Gwendal Grignou
2021-11-13 16:43 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211113164336.57f27801@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=gwendal@chromium.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox