From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Alexandru Tachici <alexandru.tachici@analog.com>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH 3/5] iio: adc: ad_sigma_delta: Add sequencer support
Date: Sat, 13 Nov 2021 18:23:34 +0000 [thread overview]
Message-ID: <20211113182334.0486a4a0@jic23-huawei> (raw)
In-Reply-To: <CAHp75Vf8+HH8t-pqXtd3=FT5=9T4T2ke+ceQ-pyAyvmH2pN9zQ@mail.gmail.com>
On Sat, 13 Nov 2021 19:00:11 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Fri, Nov 12, 2021 at 7:10 PM Jonathan Cameron <jic23@kernel.org> wrote:
> > On Wed, 10 Nov 2021 13:17:48 +0200
> > <alexandru.tachici@analog.com> wrote:
>
>
> > > + kfree(sigma_delta->samples_buf);
> >
> > krealloc() preferred. It might not be necessary to actually do an allocation after all
> > if we happen to have one we can already use.
>
> Looking at below, shouldn't it be krealloc_array()?
True
>
> > > + sigma_delta->samples_buf = kzalloc(slot * indio_dev->channels[0].scan_type.storagebits,
> > > + GFP_KERNEL);
>
>
next prev parent reply other threads:[~2021-11-13 18:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 11:17 [PATCH 0/5] iio: adc: ad_sigma_delta: Add sequencer support alexandru.tachici
2021-11-10 11:17 ` [PATCH 1/5] iio: adc: ad7124: Add update_scan_mode alexandru.tachici
2021-11-12 16:54 ` Jonathan Cameron
2021-11-10 11:17 ` [PATCH 2/5] iio: adc: ad7192: " alexandru.tachici
2021-11-12 16:57 ` Jonathan Cameron
2021-11-10 11:17 ` [PATCH 3/5] iio: adc: ad_sigma_delta: Add sequencer support alexandru.tachici
2021-11-12 17:14 ` Jonathan Cameron
2021-11-13 17:00 ` Andy Shevchenko
2021-11-13 18:23 ` Jonathan Cameron [this message]
2021-11-10 11:17 ` [PATCH 4/5] iio: adc: ad7124: add " alexandru.tachici
2021-11-10 11:17 ` [PATCH 5/5] iio: adc: ad7192: " alexandru.tachici
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211113182334.0486a4a0@jic23-huawei \
--to=jic23@kernel.org \
--cc=alexandru.tachici@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox