Re: [PATCH v2 2/3] dt-bindings: iio: Add sx9360 binding

[Jonathan Cameron <jic23@kernel.org>]

On Sat, 20 Nov 2021 02:26:33 -0800
Gwendal Grignou <gwendal@chromium.org> wrote:

> Add binding to configure Semtech sx9360 sensor.
> It is a simpler version of sx9324.
> 
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>

Trivial comment inline + this needs to go to dt list for review.

Jonathan

> ---
> Changes since v2:
> - Fix cut and paste error.
> - Add . at end of sentence.
> 
>  .../iio/proximity/semtech,sx9360.yaml         | 90 +++++++++++++++++++
>  1 file changed, 90 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/proximity/semtech,sx9360.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9360.yaml b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9360.yaml
> new file mode 100644
> index 00000000000000..326dabfb3eb2ac
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9360.yaml
> @@ -0,0 +1,90 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/proximity/semtech,sx9310.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Semtech's SX9360 capacitive proximity sensor
> +
> +maintainers:
> +  - Gwendal Grignou <gwendal@chromium.org>
> +  - Daniel Campello <campello@chromium.org>
> +
> +description: |
> +  Semtech's SX9360 proximity sensor.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - semtech,sx9360

Trivial but you changed this to const: semtech... for the other driver and could do the
same here if you aren't expecting to add other devices to this binding.

> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    description:
> +      Generated by device to announce preceding read request has finished
> +      and data is available or that a close/far proximity event has happened.
> +    maxItems: 1
> +
> +  vdd-supply:
> +    description: Main power supply
> +
> +  svdd-supply:
> +    description: Host interface power supply
> +
> +  "#io-channel-cells":
> +    const: 1
> +
> +  semtech,resolution:
> +    $ref: /schemas/types.yaml#definitions/uint32
> +    enum: [8, 16, 32, 64, 128, 256, 512, 1024]
> +    description:
> +      Capacitance measurement resolution. For both phases, "reference" and
> +      "measurement". Higher the number, higher the resolution.
> +    default: 128
> +
> +  semtech,proxraw-strength:
> +    $ref: /schemas/types.yaml#definitions/uint32
> +    min: 0
> +    max: 7
> +    default: 1
> +    description:
> +      PROXRAW filter strength for both phase. A value of 0 represents off,
> +      and other values represent 1-1/2^N.
> +
> +  semtech,avg-pos-strength:
> +    $ref: /schemas/types.yaml#definitions/uint32
> +    enum: [0, 16, 64, 128, 256, 512, 1024, 4294967295]
> +    default: 16
> +    description:
> +      Average positive filter strength. A value of 0 represents off and
> +      UINT_MAX (4294967295) represents infinite. Other values
> +      represent 1-1/N.
> +
> +required:
> +  - compatible
> +  - reg
> +  - "#io-channel-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      proximity@28 {
> +        compatible = "semtech,sx9360";
> +        reg = <0x28>;
> +        interrupt-parent = <&pio>;
> +        interrupts = <5 IRQ_TYPE_LEVEL_LOW 5>;
> +        vdd-supply = <&pp3300_a>;
> +        svdd-supply = <&pp1800_prox>;
> +        #io-channel-cells = <1>;
> +        semtech,resolution = 2;
> +        semtech,proxraw-strength = <2>;
> +        semtech,avg-pos-strength = <64>;
> +      };
> +    };