From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-iio-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 01DA6C433EF
	for <linux-iio@archiver.kernel.org>; Sat, 20 Nov 2021 17:50:22 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S236748AbhKTRxZ convert rfc822-to-8bit (ORCPT
        <rfc822;linux-iio@archiver.kernel.org>);
        Sat, 20 Nov 2021 12:53:25 -0500
Received: from mail.kernel.org ([198.145.29.99]:51502 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S236734AbhKTRxZ (ORCPT <rfc822;linux-iio@vger.kernel.org>);
        Sat, 20 Nov 2021 12:53:25 -0500
Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 2A76560E9C;
        Sat, 20 Nov 2021 17:50:18 +0000 (UTC)
Date:   Sat, 20 Nov 2021 17:55:11 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Nuno =?UTF-8?B?U8Oh?= <nuno.sa@analog.com>,
        linux-iio <linux-iio@vger.kernel.org>,
        Michael Hennerich <Michael.Hennerich@analog.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Nishant Malpani <nish.malpani25@gmail.com>,
        Kister Genesis Jimenez <kister.jimenez@analog.com>
Subject: Re: [PATCH v3] iio: adxrs290: fix data signedness
Message-ID: <20211120175511.6353f194@jic23-huawei>
In-Reply-To: <CAHp75Vc+AyaDmvssME39YO2LOY+yBb7QyNCnvNWJxYr-Of16ig@mail.gmail.com>
References: <20211115104147.18669-1-nuno.sa@analog.com>
        <CAHp75Vc+AyaDmvssME39YO2LOY+yBb7QyNCnvNWJxYr-Of16ig@mail.gmail.com>
X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk
List-ID: <linux-iio.vger.kernel.org>
X-Mailing-List: linux-iio@vger.kernel.org

On Mon, 15 Nov 2021 12:57:46 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Mon, Nov 15, 2021 at 12:41 PM Nuno Sá <nuno.sa@analog.com> wrote:
> >
> > From: Kister Genesis Jimenez <kister.jimenez@analog.com>
> >
> > Properly sign-extend the rate and temperature data.  
> 
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

Jonathan

> 
> > Fixes: 2c8920fff1457 ("iio: gyro: Add driver support for ADXRS290")
> > Signed-off-by: Kister Genesis Jimenez <kister.jimenez@analog.com>
> > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > ---
> > changes in v2:
> >  * removed redundant temp & 0xFFF.
> >
> > changes in v3:
> >  * full name in Signed-off-by tag.
> >
> >  drivers/iio/gyro/adxrs290.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/gyro/adxrs290.c b/drivers/iio/gyro/adxrs290.c
> > index 3e0734ddafe3..600e9725da78 100644
> > --- a/drivers/iio/gyro/adxrs290.c
> > +++ b/drivers/iio/gyro/adxrs290.c
> > @@ -7,6 +7,7 @@
> >   */
> >
> >  #include <linux/bitfield.h>
> > +#include <linux/bitops.h>
> >  #include <linux/delay.h>
> >  #include <linux/device.h>
> >  #include <linux/kernel.h>
> > @@ -124,7 +125,7 @@ static int adxrs290_get_rate_data(struct iio_dev *indio_dev, const u8 cmd, int *
> >                 goto err_unlock;
> >         }
> >
> > -       *val = temp;
> > +       *val = sign_extend32(temp, 15);
> >
> >  err_unlock:
> >         mutex_unlock(&st->lock);
> > @@ -146,7 +147,7 @@ static int adxrs290_get_temp_data(struct iio_dev *indio_dev, int *val)
> >         }
> >
> >         /* extract lower 12 bits temperature reading */
> > -       *val = temp & 0x0FFF;
> > +       *val = sign_extend32(temp, 11);
> >
> >  err_unlock:
> >         mutex_unlock(&st->lock);
> > --
> > 2.33.1
> >  
> 
>