Re: [PATCH] counter: ti-eqep: Enable for TDA4VM/J721E

[Jonathan Cameron <jic23@kernel.org>]

On Tue, 30 Nov 2021 15:16:28 -0600
Nishanth Menon <nm@ti.com> wrote:

> On 14:33-20211130, Jason Kridner wrote:
> > Counter TI-EQEP was tested on TDA4VM/J721E SoC.
> >   
> Thanks for doing this patch,
> You could drop the example - This is an example which is probably
> better addressed in Documentation/devicetree/bindings/counter/ti-eqep.yaml
> or in the actual device tree for j721e itself.
> 
> Instead, I would suggest to keep the commit message short:
> 
> Enable TI-QEP for TI's K3 architecture as the driver is reusable
> or something of that form.
> 
> The actual devicetree dts patch should be separate and posted once the
> driver support is enabled.
> 
> > Overlay used for testing EQEP0 and EQEP1:
> > 
> >     &cbass_main {
> > 	#address-cells = <2>;
> > 	#size-cells = <2>;
> > 
> > 	eqep0: qep@3200000 {  
> 
> 	[...]
> 
> > 	};
> >     };

Note this is perfectly reasonable detail to have in a cover letter but I agree
with Nishanth that it is too much for the patch description. 

Given we have very little for counter so far this cycle, please +CC
gregkh@linuxfoundation.org on v2.  That way we can be lazy and ask him to
queue it up directly if that makes sense at the time.

For background to this, as of last cycle I split the IIO and counter
pull requests for the first time.

Thanks,

Jonathan


> > 
> > Signed-off-by: Jason Kridner <jkridner@beagleboard.org>
> > ---
> >  drivers/counter/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> > index 2de53ab0dd25..453490059c88 100644
> > --- a/drivers/counter/Kconfig
> > +++ b/drivers/counter/Kconfig
> > @@ -51,7 +51,7 @@ config STM32_LPTIMER_CNT
> >  
> >  config TI_EQEP
> >  	tristate "TI eQEP counter driver"
> > -	depends on (SOC_AM33XX || COMPILE_TEST)
> > +	depends on (SOC_AM33XX || ARCH_K3 || COMPILE_TEST)
> >  	select REGMAP_MMIO
> >  	help
> >  	  Select this option to enable the Texas Instruments Enhanced Quadrature
> > -- 
> > 2.30.2
> >   
>