From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6794C433F5 for ; Sun, 5 Dec 2021 16:33:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235934AbhLEQgo (ORCPT ); Sun, 5 Dec 2021 11:36:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230137AbhLEQgn (ORCPT ); Sun, 5 Dec 2021 11:36:43 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80DF9C061714 for ; Sun, 5 Dec 2021 08:33:16 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 11264B80E87 for ; Sun, 5 Dec 2021 16:33:15 +0000 (UTC) Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPSA id 7191CC00446; Sun, 5 Dec 2021 16:33:12 +0000 (UTC) Date: Sun, 5 Dec 2021 16:38:23 +0000 From: Jonathan Cameron To: Andy Shevchenko Cc: Lars-Peter Clausen , linux-iio , Jonathan Cameron Subject: Re: [PATCH v2 09/12] iio:adc:ti-adc12138: Switch to generic firmware properties. Message-ID: <20211205163823.1ed4f546@jic23-huawei> In-Reply-To: References: <20211204171237.2769210-1-jic23@kernel.org> <20211204171237.2769210-10-jic23@kernel.org> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sun, 5 Dec 2021 17:13:42 +0200 Andy Shevchenko wrote: > On Sun, Dec 5, 2021 at 5:12 PM Andy Shevchenko > wrote: > > On Sat, Dec 4, 2021 at 7:07 PM Jonathan Cameron wrote: > > ... > > > > -#ifdef CONFIG_OF > > > - > > > > It's a sign that somewhere should be of_match_ptr(). > > Please, double check that you remove that as well in all conversion patches. Indeed - missed this one. I'll fix up for v3. I just checked and no others in this set. > > Also, check that you drop OF dependencies (where it's the case) from a > certain Kconfig. There were very few with an OF dependency in this set (just the ads124s08 in patch 11). Jonathan > > > > static const struct of_device_id adc12138_dt_ids[] = { > > > { .compatible = "ti,adc12130", }, > > > { .compatible = "ti,adc12132", }, >