Re: [PATCH 2/3] iio: ABI: add ABI file for the LTC2688 DAC

Jonathan Cameron
2021-12-16T13:29:51Z

On Tue, 14 Dec 2021 17:56:07 +0100
Nuno Sá <nuno.sa@analog.com> wrote:

> Define the sysfs interface for toggle or dither capable channels. Dither
> capable channels will have the extended interface:
>
> * out_voltageY_dither_en
> * out_voltageY_dither_raw
> * out_voltageY_dither_raw_available
> * out_voltageY_dither_frequency
> * out_voltageY_dither_frequency_available
> * out_voltageY_dither_phase
> * out_voltageY_dither_phase_available
>
> Toggle enabled channels will have:
>
> * out_voltageY_toggle_en
> * out_voltageY_raw1
> * out_voltageY_symbol
>
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> ---

> +What: /sys/bus/iio/devices/iio:deviceX/out_voltageY_raw1

I was thinking more raw0 and raw1 rather than not having the 0 for the
first one. If someone has the device in a circuit where they want to use
the toggle mode then I'd assume they know about the special ABI and can
cope with this.

> +KernelVersion: 5.16
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + It has the same meaning as out_voltageY_raw. This attribute is
> + specific to toggle enabled channels and refers to the DAC output
> + code in the INPUT_B register while regular out_voltageY_raw
> + refers to INPUT_A. The same scale, offset, etc applies.