RE: [PATCH 2/3] iio: ABI: add ABI file for the LTC2688 DAC

Sa, Nuno
2021-12-17T12:00:00Z

> -----Original Message-----
> From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
> Sent: Thursday, December 16, 2021 2:35 PM
> To: Sa, Nuno <Nuno.Sa@analog.com>
> Cc: linux-iio@vger.kernel.org; devicetree@vger.kernel.org; Rob
> Herring <robh+dt@kernel.org>; Lars-Peter Clausen
> <lars@metafoo.de>; Hennerich, Michael
> <Michael.Hennerich@analog.com>
> Subject: Re: [PATCH 2/3] iio: ABI: add ABI file for the LTC2688 DAC
>
> [External]
>
> On Tue, 14 Dec 2021 17:56:07 +0100
> Nuno Sá <nuno.sa@analog.com> wrote:
>
> > Define the sysfs interface for toggle or dither capable channels.
> Dither
> > capable channels will have the extended interface:
> >
> > * out_voltageY_dither_en
> > * out_voltageY_dither_raw
> > * out_voltageY_dither_raw_available
> > * out_voltageY_dither_frequency
> > * out_voltageY_dither_frequency_available
> > * out_voltageY_dither_phase
> > * out_voltageY_dither_phase_available
> >
> > Toggle enabled channels will have:
> >
> > * out_voltageY_toggle_en
> > * out_voltageY_raw1
> > * out_voltageY_symbol
> >
> > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > ---
>
> > +What:
> /sys/bus/iio/devices/iio:deviceX/out_voltageY_raw1
>
> I was thinking more raw0 and raw1 rather than not having the 0 for the
> first one. If someone has the device in a circuit where they want to
> use
> the toggle mode then I'd assume they know about the special ABI and
> can
> cope with this.
>

Hmm I see. That means more probe time handling but well, we are doing
a lot anyways that a bit more won't hurt :).

- Nuno Sá