From: Jonathan Cameron <jic23@kernel.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Antoniu Miclaus <antoniu.miclaus@analog.com>
Subject: Re: [PATCH] iio: frequency: admv1013: remove the always true condition
Date: Sat, 15 Jan 2022 18:09:41 +0000 [thread overview]
Message-ID: <20220115180941.709a667a@jic23-huawei> (raw)
In-Reply-To: <YdS3gJYtECMaDDjA@debian-BULLSEYE-live-builder-AMD64>
On Wed, 5 Jan 2022 02:09:20 +0500
Muhammad Usama Anjum <usama.anjum@collabora.com> wrote:
> unsigned int variable is always greater than or equal to zero. Make the
> if condition simple.
>
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Hi,
+ CC Antoniu and this should have a Fixes tag.
Thanks,
Jonathan
> ---
> drivers/iio/frequency/admv1013.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/frequency/admv1013.c b/drivers/iio/frequency/admv1013.c
> index 6cdeb50143af..3f3c478e9baa 100644
> --- a/drivers/iio/frequency/admv1013.c
> +++ b/drivers/iio/frequency/admv1013.c
> @@ -348,7 +348,7 @@ static int admv1013_update_mixer_vgate(struct admv1013_state *st)
>
> vcm = regulator_get_voltage(st->reg);
>
> - if (vcm >= 0 && vcm < 1800000)
> + if (vcm < 1800000)
> mixer_vgate = (2389 * vcm / 1000000 + 8100) / 100;
> else if (vcm > 1800000 && vcm < 2600000)
> mixer_vgate = (2375 * vcm / 1000000 + 125) / 100;
next prev parent reply other threads:[~2022-01-15 18:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 21:09 [PATCH] iio: frequency: admv1013: remove the always true condition Muhammad Usama Anjum
2022-01-15 18:09 ` Jonathan Cameron [this message]
2022-01-17 8:34 ` Muhammad Usama Anjum
2022-01-30 11:51 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220115180941.709a667a@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=antoniu.miclaus@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox