From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Andreas Kemnade <andreas@kemnade.info>,
linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Rosin <peda@axentia.se>
Subject: [PATCH v3 5/6] iio: afe: iio-rescale: Group rescale field assignments in ->probe()
Date: Mon, 24 Jan 2022 19:20:31 +0200 [thread overview]
Message-ID: <20220124172032.87893-5-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20220124172032.87893-1-andriy.shevchenko@linux.intel.com>
Group rescale field assignments in the ->probe() for better maintenance.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v3: new patch
drivers/iio/afe/iio-rescale.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/iio/afe/iio-rescale.c b/drivers/iio/afe/iio-rescale.c
index 774eb3044edd..8b9d2aa1502e 100644
--- a/drivers/iio/afe/iio-rescale.c
+++ b/drivers/iio/afe/iio-rescale.c
@@ -322,7 +322,7 @@ static int rescale_probe(struct platform_device *pdev)
return -ENOMEM;
rescale = iio_priv(indio_dev);
-
+ rescale->source = source;
rescale->cfg = of_device_get_match_data(dev);
rescale->numerator = 1;
rescale->denominator = 1;
@@ -338,8 +338,6 @@ static int rescale_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, indio_dev);
- rescale->source = source;
-
indio_dev->name = dev_name(dev);
indio_dev->info = &rescale_info;
indio_dev->modes = INDIO_DIRECT_MODE;
--
2.34.1
next prev parent reply other threads:[~2022-01-24 17:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 17:20 [PATCH v3 1/6] math.h: Introduce data types for fractional numbers Andy Shevchenko
2022-01-24 17:20 ` [PATCH v3 2/6] iio: adc: rn5t618: Re-use generic struct u16_fract Andy Shevchenko
2022-01-24 17:20 ` [PATCH v3 3/6] iio: adc: twl4030-madc: Re-use generic struct s16_fract Andy Shevchenko
2022-01-24 17:20 ` [PATCH v3 4/6] iio: adc: qcom-vadc-common: Re-use generic struct u32_fract Andy Shevchenko
2022-01-24 17:20 ` Andy Shevchenko [this message]
2022-01-24 17:20 ` [PATCH v3 6/6] iio: afe: iio-rescale: Re-use generic struct s32_fract Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220124172032.87893-5-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=agross@kernel.org \
--cc=andreas@kemnade.info \
--cc=bjorn.andersson@linaro.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).