From: Robert Hancock <robert.hancock@calian.com>
To: linux-iio@vger.kernel.org
Cc: anand.ashok.dumbre@xilinx.com, jic23@kernel.org, lars@metafoo.de,
robh+dt@kernel.org, michal.simek@xilinx.com,
manish.narani@xilinx.com, devicetree@vger.kernel.org,
Robert Hancock <robert.hancock@calian.com>,
Michael Tretter <m.tretter@pengutronix.de>
Subject: [PATCH v2 3/4] iio: adc: xilinx-ams: Fixed wrong sequencer register settings
Date: Thu, 27 Jan 2022 11:34:49 -0600 [thread overview]
Message-ID: <20220127173450.3684318-4-robert.hancock@calian.com> (raw)
In-Reply-To: <20220127173450.3684318-1-robert.hancock@calian.com>
Register settings used for the sequencer configuration register
were incorrect, causing some inputs to not be read properly.
Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver")
Signed-off-by: Robert Hancock <robert.hancock@calian.com>
Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>
---
drivers/iio/adc/xilinx-ams.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c
index b93864362dac..199027c93cdc 100644
--- a/drivers/iio/adc/xilinx-ams.c
+++ b/drivers/iio/adc/xilinx-ams.c
@@ -91,8 +91,8 @@
#define AMS_CONF1_SEQ_MASK GENMASK(15, 12)
#define AMS_CONF1_SEQ_DEFAULT FIELD_PREP(AMS_CONF1_SEQ_MASK, 0)
-#define AMS_CONF1_SEQ_CONTINUOUS FIELD_PREP(AMS_CONF1_SEQ_MASK, 1)
-#define AMS_CONF1_SEQ_SINGLE_CHANNEL FIELD_PREP(AMS_CONF1_SEQ_MASK, 2)
+#define AMS_CONF1_SEQ_CONTINUOUS FIELD_PREP(AMS_CONF1_SEQ_MASK, 2)
+#define AMS_CONF1_SEQ_SINGLE_CHANNEL FIELD_PREP(AMS_CONF1_SEQ_MASK, 3)
#define AMS_REG_SEQ0_MASK GENMASK(15, 0)
#define AMS_REG_SEQ2_MASK GENMASK(21, 16)
--
2.31.1
next prev parent reply other threads:[~2022-01-27 17:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 17:34 [PATCH v2 0/4] Xilinx AMS fixes Robert Hancock
2022-01-27 17:34 ` [PATCH v2 1/4] dt-bindings: iio: adc: zynqmp_ams: Add clock entry Robert Hancock
2022-02-09 20:12 ` Rob Herring
2022-01-27 17:34 ` [PATCH v2 2/4] iio: adc: xilinx-ams: Fixed missing PS channels Robert Hancock
2022-01-27 17:34 ` Robert Hancock [this message]
2022-01-27 17:34 ` [PATCH v2 4/4] iio: adc: xilinx-ams: Fix single channel switching sequence Robert Hancock
2022-01-30 12:46 ` [PATCH v2 0/4] Xilinx AMS fixes Jonathan Cameron
2022-02-09 19:49 ` Robert Hancock
2022-02-26 16:45 ` Jonathan Cameron
2022-02-28 6:40 ` Michal Simek
2022-02-28 18:26 ` Jonathan Cameron
2022-03-01 7:34 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220127173450.3684318-4-robert.hancock@calian.com \
--to=robert.hancock@calian.com \
--cc=anand.ashok.dumbre@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=m.tretter@pengutronix.de \
--cc=manish.narani@xilinx.com \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox