From: Jonathan Cameron <jic23@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Cosmin Tanislav <demonsingur@gmail.com>,
Michael Hennerich <Michael.Hennerich@analog.com>,
linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] iio: accel: adxl367: unlock on error in adxl367_buffer_predisable()
Date: Sat, 26 Feb 2022 17:58:05 +0000 [thread overview]
Message-ID: <20220226175805.1f35babb@jic23-huawei> (raw)
In-Reply-To: <20220224150228.GB6856@kili>
On Thu, 24 Feb 2022 18:02:28 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This error path needs to call the mutex_unlock(&st->lock) before
> returning.
>
> Fixes: cbab791c5e2a ("iio: accel: add ADXL367 driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied to the togreg branch of iio.git.
Jonathan
> ---
> drivers/iio/accel/adxl367.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/adxl367.c b/drivers/iio/accel/adxl367.c
> index b452d74b1d4d..bdc95409abed 100644
> --- a/drivers/iio/accel/adxl367.c
> +++ b/drivers/iio/accel/adxl367.c
> @@ -1359,7 +1359,7 @@ static int adxl367_buffer_predisable(struct iio_dev *indio_dev)
>
> ret = adxl367_set_measure_en(st, true);
> if (ret)
> - return ret;
> + goto out;
>
> ret = adxl367_set_temp_adc_mask_en(st, indio_dev->active_scan_mask,
> false);
prev parent reply other threads:[~2022-02-26 17:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 15:02 [PATCH] iio: accel: adxl367: unlock on error in adxl367_buffer_predisable() Dan Carpenter
2022-02-26 17:58 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220226175805.1f35babb@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=dan.carpenter@oracle.com \
--cc=demonsingur@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox