Re: [PATCH v10 2/9] mfd: qcom-spmi-pmic: expose the PMIC revid information to clients

kernel test robot
2022-03-08T20:46:45Z

Hi Caleb,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on jic23-iio/togreg lee-mfd/for-mfd-next linus/master v5.17-rc7 next-20220308]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Caleb-Connolly/iio-adc-introduce-Qualcomm-SPMI-Round-Robin-ADC/20220307-134408
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: openrisc-randconfig-s032-20220307 (https://download.01.org/0day-ci/archive/20220309/202203090452.rXtdakYR-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/9b8935738dc1a30c2fdcacd300b6608a99da65a2
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Caleb-Connolly/iio-adc-introduce-Qualcomm-SPMI-Round-Robin-ADC/20220307-134408
git checkout 9b8935738dc1a30c2fdcacd300b6608a99da65a2
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=openrisc SHELL=/bin/bash drivers/mfd/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)
drivers/mfd/qcom-spmi-pmic.c: note: in included file:
>> include/linux/spmi.h:168:47: sparse: sparse: marked inline, but without a definition

vim +168 include/linux/spmi.h

5a86bf343976b9c Kenneth Heitke 2014-02-12 163
5a86bf343976b9c Kenneth Heitke 2014-02-12 164 #define module_spmi_driver(__spmi_driver) \
5a86bf343976b9c Kenneth Heitke 2014-02-12 165 module_driver(__spmi_driver, spmi_driver_register, \
5a86bf343976b9c Kenneth Heitke 2014-02-12 166 spmi_driver_unregister)
5a86bf343976b9c Kenneth Heitke 2014-02-12 167
e02739c92c567a4 Caleb Connolly 2022-03-05 @168 inline struct spmi_device *spmi_device_from_of(struct device_node *np);
5a86bf343976b9c Kenneth Heitke 2014-02-12 169 int spmi_register_read(struct spmi_device *sdev, u8 addr, u8 *buf);
5a86bf343976b9c Kenneth Heitke 2014-02-12 170 int spmi_ext_register_read(struct spmi_device *sdev, u8 addr, u8 *buf,
5a86bf343976b9c Kenneth Heitke 2014-02-12 171 size_t len);
5a86bf343976b9c Kenneth Heitke 2014-02-12 172 int spmi_ext_register_readl(struct spmi_device *sdev, u16 addr, u8 *buf,
5a86bf343976b9c Kenneth Heitke 2014-02-12 173 size_t len);
5a86bf343976b9c Kenneth Heitke 2014-02-12 174 int spmi_register_write(struct spmi_device *sdev, u8 addr, u8 data);
5a86bf343976b9c Kenneth Heitke 2014-02-12 175 int spmi_register_zero_write(struct spmi_device *sdev, u8 data);
5a86bf343976b9c Kenneth Heitke 2014-02-12 176 int spmi_ext_register_write(struct spmi_device *sdev, u8 addr,
5a86bf343976b9c Kenneth Heitke 2014-02-12 177 const u8 *buf, size_t len);
5a86bf343976b9c Kenneth Heitke 2014-02-12 178 int spmi_ext_register_writel(struct spmi_device *sdev, u16 addr,
5a86bf343976b9c Kenneth Heitke 2014-02-12 179 const u8 *buf, size_t len);
5a86bf343976b9c Kenneth Heitke 2014-02-12 180 int spmi_command_reset(struct spmi_device *sdev);
5a86bf343976b9c Kenneth Heitke 2014-02-12 181 int spmi_command_sleep(struct spmi_device *sdev);
5a86bf343976b9c Kenneth Heitke 2014-02-12 182 int spmi_command_wakeup(struct spmi_device *sdev);
5a86bf343976b9c Kenneth Heitke 2014-02-12 183 int spmi_command_shutdown(struct spmi_device *sdev);
5a86bf343976b9c Kenneth Heitke 2014-02-12 184

---
0-DAY CI Kernel Test Service, Intel Corporation