Re: [PATCH 4/6] iio: adc: ti-ads1015: Deduplicate channel macros

Andy Shevchenko
2022-03-10T14:33:41Z

On Thu, Mar 10, 2022 at 01:34:00AM +0100, Marek Vasut wrote:
> These macros differ only in the number of valid bits of each ADC sample
> and the shift of those bits, i.e. ADS1015 is 12bit ADC shifted by 4 left,
> ADS1115 is 16bit ADC shifted by 0. No functional change.

> Signed-off-by: Marek Vasut <marex@denx.de>

...

> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>

You may consider using --cc parameter in `git send-email` to avoid this noise
in the commit messages.

...

> - .realbits = 12, \
> + .realbits = (_realbits), \
> .storagebits = 16, \

This seems inconsistent a bit. What if the next chip wants to have more than
16 bits in realbits?

...

> - .realbits = 16, \
> + .realbits = (_realbits), \
> .storagebits = 16, \

Ditto.

I see two options:
1) add static assert to make sure realbits <= storagebits;
2) make it also configurable.

--
With Best Regards,
Andy Shevchenko