From: Jonathan Cameron <jic23@kernel.org>
To: Alexander Vorwerk <alexander.vorwerk@stud.uni-goettingen.de>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: iio: fix a few code style issues
Date: Sun, 20 Mar 2022 13:27:07 +0000 [thread overview]
Message-ID: <20220320132707.44d2a48a@jic23-huawei> (raw)
In-Reply-To: <20220312180343.8935-1-alexander.vorwerk@stud.uni-goettingen.de>
On Sat, 12 Mar 2022 19:03:43 +0100
Alexander Vorwerk <alexander.vorwerk@stud.uni-goettingen.de> wrote:
> * Fix indent in else statement
> * Remove unnecessary 'else' after 'break'
> * Remove space in '* attr'
>
> Signed-off-by: Alexander Vorwerk <alexander.vorwerk@stud.uni-goettingen.de>
Applied to the togreg branch of iio.git and pushed out as testing to let the
autobuilders see if they can find any problems.
Note that I'll be rebasing the tree after rc1.
Thanks,
Jonathan
> ---
> drivers/iio/industrialio-buffer.c | 4 ++--
> drivers/iio/industrialio-core.c | 3 +--
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
> index 208b5193c621..15c5405853d7 100644
> --- a/drivers/iio/industrialio-buffer.c
> +++ b/drivers/iio/industrialio-buffer.c
> @@ -915,7 +915,7 @@ static int iio_verify_update(struct iio_dev *indio_dev,
> if (scan_mask == NULL)
> return -EINVAL;
> } else {
> - scan_mask = compound_mask;
> + scan_mask = compound_mask;
> }
>
> config->scan_bytes = iio_compute_scan_bytes(indio_dev,
> @@ -1649,7 +1649,7 @@ static int __iio_buffer_alloc_sysfs_and_mask(struct iio_buffer *buffer,
> }
>
> attrn = buffer_attrcount + scan_el_attrcount + ARRAY_SIZE(iio_buffer_attrs);
> - attr = kcalloc(attrn + 1, sizeof(* attr), GFP_KERNEL);
> + attr = kcalloc(attrn + 1, sizeof(*attr), GFP_KERNEL);
> if (!attr) {
> ret = -ENOMEM;
> goto error_free_scan_mask;
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index 409c278a4c2c..346c8fbf18a4 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -892,8 +892,7 @@ static int __iio_str_to_fixpoint(const char *str, int fract_mult,
> } else if (*str == '\n') {
> if (*(str + 1) == '\0')
> break;
> - else
> - return -EINVAL;
> + return -EINVAL;
> } else if (!strncmp(str, " dB", sizeof(" dB") - 1) && scale_db) {
> /* Ignore the dB suffix */
> str += sizeof(" dB") - 1;
prev parent reply other threads:[~2022-03-20 13:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-12 18:03 [PATCH] drivers: iio: fix a few code style issues Alexander Vorwerk
2022-03-20 13:27 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220320132707.44d2a48a@jic23-huawei \
--to=jic23@kernel.org \
--cc=alexander.vorwerk@stud.uni-goettingen.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox