From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Marek Vasut <marex@denx.de>,
linux-iio <linux-iio@vger.kernel.org>,
"Daniel Baluta" <daniel.baluta@nxp.com>
Subject: Re: [PATCH v3 09/10] iio: adc: ti-ads1015: Replace data_rate with chip data struct ads1015_data
Date: Tue, 22 Mar 2022 20:48:41 +0000 [thread overview]
Message-ID: <20220322204841.00000590@Huawei.com> (raw)
In-Reply-To: <YjilGMLt/Z0Kiz89@smile.fi.intel.com>
On Mon, 21 Mar 2022 18:17:28 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Mon, Mar 21, 2022 at 03:41:20PM +0100, Marek Vasut wrote:
> > On 3/21/22 10:26, Andy Shevchenko wrote:
> > > On Sun, Mar 20, 2022 at 8:14 PM Marek Vasut <marex@denx.de> wrote:
>
> ...
>
> > > > if (period <= ads1015_comp_queue[i] *
> > > > - USEC_PER_SEC / data->data_rate[dr])
> > > > + USEC_PER_SEC / data_rate[dr])
>
> if (period <= ads1015_comp_queue[i] * USEC_PER_SEC / data_rate[dr])
>
> > > I would put these two to one line.
> >
> > That'd make the line over 80 chars long, is that OK in iio now ?
Depends on readability. Where it doesn't hurt such as line breaks in
between functional parameters I prefer we stick to sub 80 chars.
>
> If not (Jonathan, what's your opinion?), you can do a better splitting
>
> if (period <=
> ads1015_comp_queue[i] * USEC_PER_SEC / data_rate[dr])
>
> although I think it's worse than putting on one line.
>
Agreed. This particular case is more readable on one line.
Thanks,
Jonathan
next prev parent reply other threads:[~2022-03-22 20:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-20 18:14 [PATCH v3 01/10] dt-bindings: iio: adc: ti,ads1015: Add missing ADS1115 compatible string Marek Vasut
2022-03-20 18:14 ` [PATCH v3 02/10] dt-bindings: iio: adc: ti,ads1015: Add TLA2024 " Marek Vasut
2022-03-20 18:14 ` [PATCH v3 03/10] iio: adc: ti-ads1015: Switch to static const writeable ranges table Marek Vasut
2022-03-20 18:14 ` [PATCH v3 04/10] iio: adc: ti-ads1015: Deduplicate channel macros Marek Vasut
2022-03-20 18:14 ` [PATCH v3 05/10] iio: adc: ti-ads1015: Make channel event_spec optional Marek Vasut
2022-03-20 18:14 ` [PATCH v3 06/10] iio: adc: ti-ads1015: Add TLA2024 support Marek Vasut
2022-03-20 18:14 ` [PATCH v3 07/10] iio: adc: ti-ads1015: Add static assert to test if shifted realbits fit into storagebits Marek Vasut
2022-03-20 18:14 ` [PATCH v3 08/10] iio: adc: ti-ads1015: Convert to OF match data Marek Vasut
2022-03-21 9:24 ` Andy Shevchenko
2022-03-22 21:00 ` Jonathan Cameron
2022-03-22 21:41 ` Marek Vasut
2022-03-20 18:14 ` [PATCH v3 09/10] iio: adc: ti-ads1015: Replace data_rate with chip data struct ads1015_data Marek Vasut
2022-03-21 9:26 ` Andy Shevchenko
2022-03-21 14:41 ` Marek Vasut
2022-03-21 16:17 ` Andy Shevchenko
2022-03-22 20:48 ` Jonathan Cameron [this message]
2022-03-20 18:14 ` [PATCH v3 10/10] iio: adc: ti-ads1015: Switch to read_avail Marek Vasut
2022-03-21 9:27 ` Andy Shevchenko
2022-03-21 14:44 ` Marek Vasut
2022-03-21 16:19 ` Andy Shevchenko
2022-03-21 19:46 ` Marek Vasut
2022-03-22 20:50 ` Jonathan Cameron
2022-03-22 21:15 ` Jonathan Cameron
2022-03-22 21:39 ` Marek Vasut
2022-03-22 22:03 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220322204841.00000590@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=linux-iio@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox