From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F1F1C433FE for ; Wed, 6 Apr 2022 18:11:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239877AbiDFSNP (ORCPT ); Wed, 6 Apr 2022 14:13:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240232AbiDFSNK (ORCPT ); Wed, 6 Apr 2022 14:13:10 -0400 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B195129862 for ; Wed, 6 Apr 2022 09:50:31 -0700 (PDT) Received: by mail-pg1-x52f.google.com with SMTP id k14so2726849pga.0 for ; Wed, 06 Apr 2022 09:50:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GW2h7uu/G+YD6BBAeZyxfMtvERVI7M6Q3BgRXDcSV4A=; b=a1KL0Vafp4K4XREnlA3e1N5MECziD/SZsjf2K+Hpuv5hfmogDWxNdlysx3Ekb7TEdn 5wsbHuueaPKFcONHLT/5VJHooiOyzZquXUwtNyRKM4phqPPG0GKMoM1XtreweA3Ixn8Z mKYJZREC9gTSGJAxjq4/9OA3961nSCP+Jzi+E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GW2h7uu/G+YD6BBAeZyxfMtvERVI7M6Q3BgRXDcSV4A=; b=w1aClTolDDTkzV29dYfIkqKzwWUkavMl2/3UkL1L1/lOGXHAQaCsNfc7mrjVo5370D uxXUiA6dSU6uAYbZHmK73RzBgbG8U9zvz9CR7J4bVbVlObOJgO14Drx0JE6TNUtooyuG gkebUQqxAsXEDXh7w79WMj2Ks6S06tfR3On5NkH9Fd0Ibag8TgpuPSS3VBkBk/2Nd4CL MRSk85jFqsbHEc8Bu+MJSJnPJpFbnG3+U+UfQkqxjc0WXqxFx4iR0eMdTvPe0alrkMY/ Kg2T9nf7K8I3PEAGZICMAbPJzQ3duqB4fdmJJptX9Furkqf1gY+KEnJpdsqdt5uJyAnc 8blA== X-Gm-Message-State: AOAM530voyWVcMsHcAEDLEwvSEiAul9KqH71TFMcJLLfxWU6Ve8ZmLY/ ZRwDwjuJU2dl8Tl5ZxFn+ZGoNA== X-Google-Smtp-Source: ABdhPJzw8im6C+w2FNo2HMIGFsmoGHqaaZ0XpHY9mxxQOUtuyAq8unohXz0ANiytA4yABbl1dnmDtw== X-Received: by 2002:a63:5023:0:b0:399:2202:2f80 with SMTP id e35-20020a635023000000b0039922022f80mr7766059pgb.621.1649263830920; Wed, 06 Apr 2022 09:50:30 -0700 (PDT) Received: from localhost ([2620:15c:202:201:c9d3:469f:91e4:c022]) by smtp.gmail.com with UTF8SMTPSA id x5-20020aa79a45000000b00504a1c8b75asm101255pfj.165.2022.04.06.09.50.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Apr 2022 09:50:30 -0700 (PDT) From: Gwendal Grignou To: jic23@kernel.org, robh+dt@kernel.org, swboyd@chromium.org Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, Gwendal Grignou , stable@vger.kernel.org Subject: [PATCH v4 1/8] iio: sx9324: Fix default precharge internal resistance register Date: Wed, 6 Apr 2022 09:50:04 -0700 Message-Id: <20220406165011.10202-2-gwendal@chromium.org> X-Mailer: git-send-email 2.35.1.1094.g7c7d902a7c-goog In-Reply-To: <20220406165011.10202-1-gwendal@chromium.org> References: <20220406165011.10202-1-gwendal@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Fix the default value for the register that set the resistance: it has to be 0x10 per datasheet. Fixes: 4c18a890dff8d ("iio:proximity:sx9324: Add SX9324 support") Cc: stable@vger.kernel.org Signed-off-by: Gwendal Grignou --- Changes since v3: - Fix commit, use RESERVED instead of RSVD. Changes since v2: - no changes Changes since v1: - new patch. drivers/iio/proximity/sx9324.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/iio/proximity/sx9324.c b/drivers/iio/proximity/sx9324.c index 0d9bbbb50cb45..378c2a17bae6e 100644 --- a/drivers/iio/proximity/sx9324.c +++ b/drivers/iio/proximity/sx9324.c @@ -70,7 +70,8 @@ #define SX9324_REG_AFE_PH2 0x2a #define SX9324_REG_AFE_PH3 0x2b #define SX9324_REG_AFE_CTRL8 0x2c -#define SX9324_REG_AFE_CTRL8_RESFILTN_4KOHM 0x02 +#define SX9324_REG_AFE_CTRL8_RESERVED 0x10 +#define SX9324_REG_AFE_CTRL8_RESFILTIN_4KOHM 0x02 #define SX9324_REG_AFE_CTRL9 0x2d #define SX9324_REG_AFE_CTRL9_AGAIN_1 0x08 @@ -781,7 +782,8 @@ static const struct sx_common_reg_default sx9324_default_regs[] = { { SX9324_REG_AFE_PH2, 0x1a }, { SX9324_REG_AFE_PH3, 0x16 }, - { SX9324_REG_AFE_CTRL8, SX9324_REG_AFE_CTRL8_RESFILTN_4KOHM }, + { SX9324_REG_AFE_CTRL8, SX9324_REG_AFE_CTRL8_RESERVED | + SX9324_REG_AFE_CTRL8_RESFILTIN_4KOHM }, { SX9324_REG_AFE_CTRL9, SX9324_REG_AFE_CTRL9_AGAIN_1 }, { SX9324_REG_PROX_CTRL0, SX9324_REG_PROX_CTRL0_GAIN_1 | -- 2.35.1.1094.g7c7d902a7c-goog