Re: [PATCH v3 13/13] iio: core: Clarify the modes

Jonathan Cameron
2022-04-10T15:19:56Z

On Tue, 5 Apr 2022 10:02:00 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> Hi Jonathan,
>
> miquel.raynal@bootlin.com wrote on Tue, 15 Mar 2022 16:44:50 +0100:
>
> > Hello,
> >
> > + Christophe
> >
> > jic23@kernel.org wrote on Sun, 27 Feb 2022 13:35:49 +0000:
> >
> > > On Mon, 14 Feb 2022 09:53:08 +0100
> > > Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > >
> > > > Hi Jonathan,
> > > >
> > > > jic23@kernel.org wrote on Sun, 13 Feb 2022 18:42:24 +0000:
> > > >
> > > > > On Mon, 7 Feb 2022 15:38:40 +0100
> > > > > Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > > > >
> > > > > > As part of a previous discussion with Jonathan Cameron [1], it appeared
> > > > > > necessary to clarify the meaning of each mode so that new developers
> > > > > > could understand better what they should use or not use and when.
> > > > > >
> > > > > > The idea of renaming these modes as been let aside because naming is a
> > > > > > big deal and requires a lot of thinking. So for now let's focus on
> > > > > > correctly explaining what each mode implies.
> > > > > >
> > > > > > [1] https://lore.kernel.org/linux-iio/20210930165510.2295e6c4@jic23-huawei/
> > > > > >
> > > > > > Suggested-by: Jonathan Cameron <jic23@kernel.org>
> > > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > > > > One trivial thing inline as a result of edits in v3.
> > > > >
> > > > > Otherwise, I want to let this series sit a little longer and ideally get
> > > > > some eyes on the st_sensors patches.
>
> Sometimes there is no other choice than applying patches to get
> feedback :) Hopefully nothing unexpected will happen, but as this
> series lived almost two month on the mailing list already, I would
> propose to merge the series as it is. We can still drop/revert it as we
> are rather soon in the new cycle. If rebasing is needed just let me
> know.

Fully agree on pushing forwards with merging this. I've done the rebase whilst
applying. Other than a bit of fuzz main change was that adxl367 made use
of a kfifo buffer in the meantime so needed updating as well to drop the
buffer type parameter.

Take a quick look and see if I messed anything up.
Applied to the togreg branch of iio.git and pushed out as testing for 0-day
etc to take a poke at it before I make a mess of linux-next.

Thanks,

Jonathan

>
> Cheers,
> Miquèl
>
> > > >
> > > > Sure.
> > >
> > > Denis, Linus, Lorenzo,
> > >
> > > If any of you have time to take a look at patches 4-8 in this series or ideally
> > > to run basic sanity tests with series in place that would be great.
> > > https://patchwork.kernel.org/project/linux-iio/list/?series=611853
> > >
> > > I don't have a convenient platform to test that driver on any more and the
> > > changes are invasive enough to make me a little nervous about taking the
> > > series without someone more familiar with that driver taking a look.
> >
> > I'm adding Christophe from ST who might also help having these patches
> > tested or at least reviewed.
> >
> > TLDR: as part of a wider cleanup, I ended up "playing" with locks in
> > the st_sensors drivers, so any testing or feedback is welcome!
> >
> > Thanks,
> > Miquèl
>
>