From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E4F4C433EF for ; Sun, 10 Apr 2022 16:37:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236669AbiDJQkA (ORCPT ); Sun, 10 Apr 2022 12:40:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236179AbiDJQkA (ORCPT ); Sun, 10 Apr 2022 12:40:00 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A257448318 for ; Sun, 10 Apr 2022 09:37:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 528A2B80B00 for ; Sun, 10 Apr 2022 16:37:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EAEE9C385A4; Sun, 10 Apr 2022 16:37:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649608666; bh=r1qq+xThA1fwXMqWlPxqZgytiBue7yQjaPp3egl3PuM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Shk018oIDDcMqgOPZSvUB9oz4lIlteSIo7P/ZtRoVQKNrLo0HwL0OiqQaNkonHJ2J XCZv9KOxr/0sNpVwcJCv9qV28fha3hbL1jbft24cT7gdA91oRh3KHsKZFZyCu+LBEX U9vhjfUdsL9LzJMUQVSZWMGrW27Q22y/CsQwpUntUNwqORzIlRaQUWC4T+rSxX2Eku 8wJlCgWhAeAgkaByaLWi7q787XVaVmQcAXoFWXuoTT5hArLbz1oqD4+R+35bk33DmF 5IE3NZ+/oQVY34vvSvNFc1AAn2R8hZBUTRZq/L00RXuoeVvFLL0dzCryoZ0jbPdUTV NkYKdIxTzGXTQ== Date: Sun, 10 Apr 2022 17:45:39 +0100 From: Jonathan Cameron To: Cc: , Subject: Re: [PATCH] iio: dac: ad5446: Fix read_raw not returning set value Message-ID: <20220410174539.0fb10e34@jic23-huawei> In-Reply-To: <20220406105620.1171340-1-michael.hennerich@analog.com> References: <20220406105620.1171340-1-michael.hennerich@analog.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, 6 Apr 2022 12:56:20 +0200 wrote: > From: Michael Hennerich > > read_raw should return the un-scaled value. > > Fixes: 5e06bdfb46e8b ("staging:iio:dac:ad5446: Return cached value for 'raw' attribute") Fixes tags are part of the main tag block, so no blank line here. > > Signed-off-by: Michael Hennerich Applied to the fixes-togreg branch of iio.git and marked for stable. > --- > drivers/iio/dac/ad5446.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c > index 14cfabacbea5..fdf824041497 100644 > --- a/drivers/iio/dac/ad5446.c > +++ b/drivers/iio/dac/ad5446.c > @@ -178,7 +178,7 @@ static int ad5446_read_raw(struct iio_dev *indio_dev, > > switch (m) { > case IIO_CHAN_INFO_RAW: > - *val = st->cached_val; > + *val = st->cached_val >> chan->scan_type.shift; > return IIO_VAL_INT; > case IIO_CHAN_INFO_SCALE: > *val = st->vref_mv;