From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B337DC433EF for ; Sat, 16 Apr 2022 10:40:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231473AbiDPKml (ORCPT ); Sat, 16 Apr 2022 06:42:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231470AbiDPKmj (ORCPT ); Sat, 16 Apr 2022 06:42:39 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 268F014002; Sat, 16 Apr 2022 03:40:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D41E5B81D17; Sat, 16 Apr 2022 10:40:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BEBA6C385A3; Sat, 16 Apr 2022 10:40:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650105604; bh=Oos9yoNwh3SAMIWdcwpd3Xw5BoBg+r+ad8P3SM2AUEc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Wu8fNiou8nfeGGtUNnSnv4UUdrbM4GFT123skfFr+xm4M7digTpwJTZrL9325fKil hB/xTx9yvDQgYjSHv7l3bQYup3RsbXyqeostsyGNYKZpIfoVRxuOJJuPyW4gvysNM2 uWm7j8PNyDUrhU6XHdqK7OWR7ICq1sRkY1BjO4ihP8KKbWETplnIhikxPH/pnmkpFb GL/e/qx/CtcIUu5j+O6x5wYw6azRsjVCa9s2csisqZb3X1LusRcfXP+KPoaenAQDP8 nczplE/l0J7dQgcJ/o8ZS5u4MTgCUse2EFEMCc908LF1dw+j4FIb8va5b4OZLj87oW /8Au3mIdpZ1iw== Date: Sat, 16 Apr 2022 11:48:01 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Navin Sankar Velliangiri , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Lars-Peter Clausen Subject: Re: [PATCH v1 1/1] iio: temperature: max31865: Make use of device properties Message-ID: <20220416114801.0865fcba@jic23-huawei> In-Reply-To: <20220413185335.21743-1-andriy.shevchenko@linux.intel.com> References: <20220413185335.21743-1-andriy.shevchenko@linux.intel.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, 13 Apr 2022 21:53:35 +0300 Andy Shevchenko wrote: > Convert the module to be property provider agnostic and allow > it to be used on non-OF platforms. This one should call out the addition of missing mod_devicetable.h If nothing else comes up I can add that whilst applying. Looks fine to me but I'd like to give a little time for Navin to comment if they wish. Jonathan > > Signed-off-by: Andy Shevchenko > --- > drivers/iio/temperature/max31865.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/temperature/max31865.c b/drivers/iio/temperature/max31865.c > index 86c3f3509a26..e3bb78184c6e 100644 > --- a/drivers/iio/temperature/max31865.c > +++ b/drivers/iio/temperature/max31865.c > @@ -12,9 +12,11 @@ > #include > #include > #include > +#include > #include > #include > #include > +#include > #include > #include > > @@ -305,7 +307,7 @@ static int max31865_probe(struct spi_device *spi) > indio_dev->channels = max31865_channels; > indio_dev->num_channels = ARRAY_SIZE(max31865_channels); > > - if (of_property_read_bool(spi->dev.of_node, "maxim,3-wire")) { > + if (device_property_read_bool(&spi->dev, "maxim,3-wire")) { > /* select 3 wire */ > data->three_wire = 1; > } else {