Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Nuno Sá" <nuno.sa@analog.com>
Cc: <linux-iio@vger.kernel.org>, Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v2] iio: dac: ltc2688: fix voltage scale read
Date: Sat, 16 Apr 2022 15:01:28 +0100	[thread overview]
Message-ID: <20220416150128.1980889d@jic23-huawei> (raw)
In-Reply-To: <20220412124916.61-1-nuno.sa@analog.com>

On Tue, 12 Apr 2022 14:49:16 +0200
Nuno Sá <nuno.sa@analog.com> wrote:

> Properly set *val2 (and not overwrite *val) to correctly return
> IIO_VAL_FRACTIONAL_LOG2.
> 
> Fixes: 832cb9eeb9312 ("iio: dac: add support for ltc2688")
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Dropped v1 and applied this instead.  

If you detect an issue with a patch you have sent yourself, it is helpful
to reply to that patch to make it clear there will be a v2.
I don't always catch up with all my email in one sitting so can end up
pushing the wrong versions out....

Thanks,

Jonathan

> ---
> v2:
>  * Fixed repeated "not" in commit description and tweaked patch subject
> to match the preferred format.
> 
>  drivers/iio/dac/ltc2688.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/ltc2688.c b/drivers/iio/dac/ltc2688.c
> index d249fa28202c..937b0d25a11c 100644
> --- a/drivers/iio/dac/ltc2688.c
> +++ b/drivers/iio/dac/ltc2688.c
> @@ -298,7 +298,7 @@ static int ltc2688_read_raw(struct iio_dev *indio_dev,
>  		if (ret)
>  			return ret;
>  
> -		*val = 16;
> +		*val2 = 16;
>  		return IIO_VAL_FRACTIONAL_LOG2;
>  	case IIO_CHAN_INFO_CALIBBIAS:
>  		ret = regmap_read(st->regmap,


      reply	other threads:[~2022-04-16 13:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-12 12:49 [PATCH v2] iio: dac: ltc2688: fix voltage scale read Nuno Sá
2022-04-16 14:01 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220416150128.1980889d@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox