From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE401C433FE for ; Sat, 16 Apr 2022 14:59:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232364AbiDPPCE (ORCPT ); Sat, 16 Apr 2022 11:02:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232057AbiDPPCD (ORCPT ); Sat, 16 Apr 2022 11:02:03 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13CC33982A; Sat, 16 Apr 2022 07:59:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C1536B80022; Sat, 16 Apr 2022 14:59:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56A48C385A1; Sat, 16 Apr 2022 14:59:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650121169; bh=coBVcfYih5I6hNLMXKgpnXIwmxAmuuAnGjxElFDCC5Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=L9X/6vJ0A+BCzGCKNnz5PM6lwcEJk7+//9QuwSyN/94PKlN2Gujo83fcwl3mG0DKP OSVpNLT7H/yRzaZxxA4YxjFprW/+G0a3ciAO83tuOzpwYP6Mk+oB0buiepDmQ9y6jP hBzE3r97sHzMXzhwxi3WKsrwvILduESMHzBIog0IOzRDbxQQtYSmVFfsbSPH9jNY24 R4HLNaTvcAGVy4zhbcvMZudjn455bxhtkNUlrB7TDG8+gVgrw4uEq9cFFk39p4zlfZ OG4baSddFuIe5HXQrgj32tzEwirME3zoq9p4QByBQ9Fk54dyXeHOF6ZsCNWb4Kwnbz A/Y3ex3klYt7Q== Date: Sat, 16 Apr 2022 16:07:25 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Cosmin Tanislav , Rob Herring , Linus Walleij , linux-iio , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , devicetree , Cosmin Tanislav Subject: Re: [PATCH v1 3/3] iio: adc: ad4130: add AD4130 driver Message-ID: <20220416160725.51f0b8f0@jic23-huawei> In-Reply-To: References: <20220413094011.185269-1-cosmin.tanislav@analog.com> <20220413094011.185269-3-cosmin.tanislav@analog.com> <80196942-4c33-7625-3945-86ce5b7b347f@gmail.com> <0823cf19-60b5-3050-0e26-04b87a7ce5c0@gmail.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org > ... > > > >>>> + out: > > >>> > > >>> out_unlock: ? > > >>> Ditto for similar cases. > > >> > > >> There's a single label in the function, and there's a mutex being > > >> taken, and, logically, the mutex must be released on the exit path. > > >> It's clear what the label is for to me. > > > > > > Wasn't clear to me until I went to the end of each of them (who > > > guarantees that's the case for all of them?). > > > > Let's hope other people looking at that code will be able to figure out > > what that label does then. > > OK. Let the maintainer decide. Slight preference for giving the extra info of out_unlock, but not critical. (note I haven't read the code yet so might change my mind :)