From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B823EC433EF for ; Sun, 1 May 2022 17:43:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353467AbiEARqj (ORCPT ); Sun, 1 May 2022 13:46:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353439AbiEARqj (ORCPT ); Sun, 1 May 2022 13:46:39 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E1302E6B8 for ; Sun, 1 May 2022 10:43:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0248EB80E94 for ; Sun, 1 May 2022 17:43:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B86AC385AA; Sun, 1 May 2022 17:43:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651426990; bh=gJMotqPUbtpgfh8PZrJZqjI/v21UJxwiAwPDb1AOw4M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GlRCNNep1M5mzw7Qr92mHCQOoQUz5GEUtZ777vdochk2Tsqfm6nGFKL01473OR5sU E7/8IIqVB6yMoAdg8zu6gEAxzGBclI47Pw2qQLPUg3n5VnneFt7gCqwT9QVuwx+rvK VeB2g0nbw8CcWjBfsb2qLlAS8ccA4Mcf4IM0z+C4X9vxAkwbgCEgMycaUJ42jbMfKd YdaWUPT56GpZJ+Qs76tN76YrixCrrz6u13lBg3TmzUbVV8HxfvmTFV5ALT4e2eT6jX dUNd986UhuBE/7GYTolitYfhluYd7mBDBdkjmt+0tq8L9axK0dEIyJ1tgnZm02xDEH UPev0Q8DHAQOQ== Date: Sun, 1 May 2022 18:51:23 +0100 From: Jonathan Cameron To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Lars-Peter Clausen , Paul Cercueil , Hans de Goede , linux-iio@vger.kernel.org, Andy Shevchenko , Alexandru Ardelean , Gwendal Grignou , Guenter Roeck , Linus Walleij , Mauro Carvalho Chehab , Jiri Valek - 2N , Colin Ian King , Brian Masney Subject: Re: [PATCH 0/9] iio: Remove duplicated error reporting in .remove() Message-ID: <20220501185123.3ba0367b@jic23-huawei> In-Reply-To: <20220501184149.10b40610@jic23-huawei> References: <20220430081607.15078-1-u.kleine-koenig@pengutronix.de> <20220501184149.10b40610@jic23-huawei> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sun, 1 May 2022 18:41:49 +0100 Jonathan Cameron wrote: > On Sat, 30 Apr 2022 10:15:58 +0200 > Uwe Kleine-K=C3=B6nig wrote: >=20 > > Hello, > >=20 > > this series adapts several i2c drivers that emit two error messages if > > something in their remove function fails. The relevant issue is that the > > i2c core emits an error message if the remove callback returns a > > non-zero value but the drivers already emit a (better) message. So > > these patches change the drivers to return 0 even after an error. Note > > there is no further error handling in the i2c core, if a remove callback > > returns an error code, the device is removed anyhow, so the only effect > > of making the return value zero is that the error message is suppressed. > >=20 > > The motivation for this series is to eventually change the prototype of > > the i2c remove callback to return void. As a preparation all remove > > functions should return 0 such that changing the prototype doesn't > > change behaviour of individual drivers. =20 >=20 > I think I'd rather have seen these called out as simply moving towards > this second change as it feels wrong to deliberately not report an error > so as to avoid repeated error messages! >=20 > Meh, I don't care that strongly and you call out the real reason in each > patch. Series looks fine to me, but I'll leave the on list for a few days to let others have time to take a look. Worth noting that some of these are crying out for use of devm_add_action_or_reset() and getting rid of the remove functions entirely now you've dropped the oddity of them returning non 0. Low hanging fruit for any newbies who want to do it, or maybe I will if I get bored :) Thanks, Jonathan >=20 > >=20 > > Best regards > > Uwe > >=20 > > Uwe Kleine-K=C3=B6nig (9): > > iio:accel:mc3230: Remove duplicated error reporting in .remove() > > iio:accel:stk8312: Remove duplicated error reporting in .remove() > > iio:accel:stk8ba50: Remove duplicated error reporting in .remove() > > iio:light:bh1780: Remove duplicated error reporting in .remove() > > iio:light:isl29028: Remove duplicated error reporting in .remove() > > iio:light:jsa1212: Remove duplicated error reporting in .remove() > > iio:light:opt3001: Remove duplicated error reporting in .remove() > > iio:light:stk3310: Remove duplicated error reporting in .remove() > > iio:light:tsl2583: Remove duplicated error reporting in .remove() > >=20 > > drivers/iio/accel/mc3230.c | 4 +++- > > drivers/iio/accel/stk8312.c | 4 +++- > > drivers/iio/accel/stk8ba50.c | 4 +++- > > drivers/iio/light/bh1780.c | 7 +++---- > > drivers/iio/light/isl29028.c | 4 +++- > > drivers/iio/light/jsa1212.c | 4 +++- > > drivers/iio/light/opt3001.c | 3 +-- > > drivers/iio/light/stk3310.c | 5 ++++- > > drivers/iio/light/tsl2583.c | 4 +++- > > 9 files changed, 26 insertions(+), 13 deletions(-) > >=20 > >=20 > > base-commit: 3123109284176b1532874591f7c81f3837bbdc17 =20 >=20