From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2248C433EF for ; Sat, 14 May 2022 13:23:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232440AbiENNXW (ORCPT ); Sat, 14 May 2022 09:23:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232399AbiENNXV (ORCPT ); Sat, 14 May 2022 09:23:21 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E08EF75 for ; Sat, 14 May 2022 06:23:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 112DFB808D3 for ; Sat, 14 May 2022 13:23:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B6C4C340EE; Sat, 14 May 2022 13:23:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652534597; bh=eJ8dQbEl95WgAiZ9zbi2LXYQHkxKysM6Ur2WnGJQKNI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pRVB5w0s5RrDZ3Sr7n/hGQtAfAJBQlldUu9N5l3R8gTmPIMF2Xh19370ottzt0mqZ Fzwb5Ae90NASGF4PXBmmQz79a6Y+wts9zBAUE8GOKK7aJKlc46i8U+JNCx/zcrOJIo 50VMRzv+aBFkfUz464FevHTxPI1GieCHYtuFmQGnKo2o3sTQsm3c6pqOykUjjE2FKw WULptX6SM76Jth7zWC75eoCtbmcCekzCwkVuiHvcrh+S910rgEGnMQMqvJAhamsliQ IJgkpiU0V62PR3z0b1p8FySHICkVp/BVyHiBGFJnwwafsIGAVq/m132zi2vEk4RkOj 1k5Gw0YblGJgw== Date: Sat, 14 May 2022 14:31:51 +0100 From: Jonathan Cameron To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Lars-Peter Clausen , Paul Cercueil , Hans de Goede , linux-iio@vger.kernel.org, Andy Shevchenko , Alexandru Ardelean , Gwendal Grignou , Guenter Roeck , Linus Walleij , Mauro Carvalho Chehab , Jiri Valek - 2N , Colin Ian King , Brian Masney Subject: Re: [PATCH 0/9] iio: Remove duplicated error reporting in .remove() Message-ID: <20220514143151.52f514a0@jic23-huawei> In-Reply-To: <20220513072424.kudt3whbgpt3ryih@pengutronix.de> References: <20220430081607.15078-1-u.kleine-koenig@pengutronix.de> <20220501184149.10b40610@jic23-huawei> <20220501185123.3ba0367b@jic23-huawei> <20220507153855.6174601e@jic23-huawei> <20220513072424.kudt3whbgpt3ryih@pengutronix.de> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Fri, 13 May 2022 09:24:24 +0200 Uwe Kleine-K=C3=B6nig wrote: > Hello Jonathan, >=20 > On Sat, May 07, 2022 at 03:38:55PM +0100, Jonathan Cameron wrote: > > On Sun, 1 May 2022 18:51:23 +0100 > > Jonathan Cameron wrote: > > =20 > > > On Sun, 1 May 2022 18:41:49 +0100 > > > Jonathan Cameron wrote: > > > =20 > > > > On Sat, 30 Apr 2022 10:15:58 +0200 > > > > Uwe Kleine-K=C3=B6nig wrote: > > > > =20 > > > > > Hello, > > > > >=20 > > > > > this series adapts several i2c drivers that emit two error messag= es if > > > > > something in their remove function fails. The relevant issue is t= hat the > > > > > i2c core emits an error message if the remove callback returns a > > > > > non-zero value but the drivers already emit a (better) message. So > > > > > these patches change the drivers to return 0 even after an error.= Note > > > > > there is no further error handling in the i2c core, if a remove c= allback > > > > > returns an error code, the device is removed anyhow, so the only = effect > > > > > of making the return value zero is that the error message is supp= ressed. > > > > >=20 > > > > > The motivation for this series is to eventually change the protot= ype of > > > > > the i2c remove callback to return void. As a preparation all remo= ve > > > > > functions should return 0 such that changing the prototype doesn't > > > > > change behaviour of individual drivers. =20 > > > >=20 > > > > I think I'd rather have seen these called out as simply moving towa= rds > > > > this second change as it feels wrong to deliberately not report an = error > > > > so as to avoid repeated error messages! > > > >=20 > > > > Meh, I don't care that strongly and you call out the real reason in= each > > > > patch. =20 > > >=20 > > > Series looks fine to me, but I'll leave the on list for a few days to= let > > > others have time to take a look. > > >=20 > > > Worth noting that some of these are crying out for use > > > of devm_add_action_or_reset() and getting rid of the remove functions > > > entirely now you've dropped the oddity of them returning non 0. > > >=20 > > > Low hanging fruit for any newbies who want to do it, or maybe I will > > > if I get bored :) =20 > >=20 > > Series applied to the togreg branch of iio.git and pushed out as testin= g for > > 0-day to see if it can find anything we missed. =20 >=20 > They are in testing > (https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/log/?h=3Dt= esting) > but not in togreg > (https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/log/?h=3Dt= ogreg). >=20 > Not sure if that is how it's supposed to be? Only togreg seems to be in > next. Yup. That's intentional because I don't rebase the togreg branch unless something goes wrong when it hits next. The intent being it's a stable base to build upon. Normally there is a delay of up to a week to let 0-day take a look at testing and for me to happen to get time sat at the right computer, but sometimes it's longer :( Right now I'm waiting on a pull request being picked up by Greg KH, after which I'll fast forward the togreg branch as I have some patches waiting to be queued up that are dependent on things that have reached char-misc-next via other paths. Unfortunately I'm doubtful about whether I can squeeze in a second pull request this cycle, so they may get queued up for next cycle. A bit of bad timing :( Jonathan >=20 > Best regards > Uwe >=20