From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08A23C433F5 for ; Sat, 14 May 2022 13:41:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232847AbiENNlk (ORCPT ); Sat, 14 May 2022 09:41:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232763AbiENNlP (ORCPT ); Sat, 14 May 2022 09:41:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9337F1CFC0; Sat, 14 May 2022 06:41:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DA2DB60EFE; Sat, 14 May 2022 13:41:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3F34C340EE; Sat, 14 May 2022 13:41:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652535670; bh=cVPc8IxLVs5l5GfO+OTpaS1oTxpwAgb4hn1moAJyGJw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BfwymUFfcpF0xX+ohmRqugaY5uNQQiIsZhcVsOJ7srIDsHdnD/rk8mpyGUW/E1wXi 3TrLJ/fCFjf3cdl+MbCYrh/f8xzwGDOFtHgJ5l1dOHrFuy9CmLRkBrzDSAj4uW+Xgg sjaGfYmQ86vC/gUZNZt9J9cATz9BYHxh+4cBxJDWrPGlpVEs3pH4JUHrTzt1VS2wv2 kkhdKxb+AGwamgHMI+27pNS6j8h28iF6OVC4FmAsPcqYXBtrfmzxBn/Pns+chQfdZF KRz8NbEWGlaDJnTIZRzUpAIdMAEiocfuXRyM6jarMrVd5IUccNmR4acUf34C9GMxxs I5BhqFLd8kTXA== Date: Sat, 14 May 2022 14:49:44 +0100 From: Jonathan Cameron To: Michal Simek Cc: , , , , , , , Lv Ruyi , Zeal Robot Subject: Re: [PATCH] iio: adc: fix return error variable Message-ID: <20220514144944.21709427@jic23-huawei> In-Reply-To: References: <20220509072405.1118019-1-lv.ruyi@zte.com.cn> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 9 May 2022 09:34:57 +0200 Michal Simek wrote: > On 5/9/22 09:24, cgel.zte@gmail.com wrote: > > From: Lv Ruyi Applied, with modified patch title. There are a lot of ADC drivers so you should include the name of the driver in the patch description. iio: adc: xilinx-ams: fix return error variable > > > > Return irq instead of ret which always equals to zero here. > > > > Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver") > > Reported-by: Zeal Robot > > Signed-off-by: Lv Ruyi > > --- > > drivers/iio/adc/xilinx-ams.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c > > index a55396c1f8b2..a7687706012d 100644 > > --- a/drivers/iio/adc/xilinx-ams.c > > +++ b/drivers/iio/adc/xilinx-ams.c > > @@ -1409,7 +1409,7 @@ static int ams_probe(struct platform_device *pdev) > > > > irq = platform_get_irq(pdev, 0); > > if (irq < 0) > > - return ret; > > + return irq; > > > > ret = devm_request_irq(&pdev->dev, irq, &ams_irq, 0, "ams-irq", > > indio_dev); > > Reviewed-by: Michal Simek > > Thanks, > Michal