From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>
Subject: [PATCH v1 1/1] iio: adc: mxs-lradc-adc: Get rid of OF specifics
Date: Mon, 30 May 2022 20:33:24 +0300 [thread overview]
Message-ID: <20220530173324.921-1-andriy.shevchenko@linux.intel.com> (raw)
First of all, the additional conversion from vIRQ, and this is exactly
what is returned by platform_get_irq_byname(), to vIRQ is not needed.
Hence, drop no-op call to irq_of_parse_and_map().
Second, assign the firmware node instead of of_node.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/iio/adc/mxs-lradc-adc.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/iio/adc/mxs-lradc-adc.c b/drivers/iio/adc/mxs-lradc-adc.c
index bca79a93cbe4..25292bb8a13f 100644
--- a/drivers/iio/adc/mxs-lradc-adc.c
+++ b/drivers/iio/adc/mxs-lradc-adc.c
@@ -17,7 +17,6 @@
#include <linux/mfd/core.h>
#include <linux/mfd/mxs-lradc.h>
#include <linux/module.h>
-#include <linux/of_irq.h>
#include <linux/platform_device.h>
#include <linux/sysfs.h>
@@ -692,7 +691,7 @@ static int mxs_lradc_adc_probe(struct platform_device *pdev)
struct mxs_lradc_adc *adc;
struct iio_dev *iio;
struct resource *iores;
- int ret, irq, virq, i, s, n;
+ int ret, irq, i, s, n;
u64 scale_uv;
const char **irq_name;
@@ -721,7 +720,7 @@ static int mxs_lradc_adc_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, iio);
iio->name = pdev->name;
- iio->dev.of_node = dev->parent->of_node;
+ device_set_node(&iio->dev, dev_fwnode(dev->parent));
iio->info = &mxs_lradc_adc_iio_info;
iio->modes = INDIO_DIRECT_MODE;
iio->masklength = LRADC_MAX_TOTAL_CHANS;
@@ -747,9 +746,7 @@ static int mxs_lradc_adc_probe(struct platform_device *pdev)
if (irq < 0)
return irq;
- virq = irq_of_parse_and_map(dev->parent->of_node, irq);
-
- ret = devm_request_irq(dev, virq, mxs_lradc_adc_handle_irq,
+ ret = devm_request_irq(dev, irq, mxs_lradc_adc_handle_irq,
0, irq_name[i], iio);
if (ret)
return ret;
--
2.35.1
next reply other threads:[~2022-05-30 17:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-30 17:33 Andy Shevchenko [this message]
2022-06-03 17:10 ` [PATCH v1 1/1] iio: adc: mxs-lradc-adc: Get rid of OF specifics Jonathan Cameron
2022-06-20 19:42 ` Jonathan Cameron
2022-09-06 13:36 ` Andy Shevchenko
2022-09-11 9:52 ` Jonathan Cameron
2022-09-12 10:21 ` Andy Shevchenko
2022-09-12 10:24 ` Andy Shevchenko
2022-06-20 21:13 ` Fabio Estevam
[not found] ` <CAHp75Vd9yah3D8dUOPinhj=nm9GQs3xOsWZRL=6CvaROZC3OCQ@mail.gmail.com>
2022-06-20 21:56 ` Fabio Estevam
2022-06-21 10:26 ` Andy Shevchenko
2022-06-21 10:35 ` Andy Shevchenko
2022-06-21 10:58 ` Andy Shevchenko
2022-06-21 11:06 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220530173324.921-1-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=festevam@gmail.com \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).