From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 310B8C43334 for ; Fri, 3 Jun 2022 17:01:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344154AbiFCRBJ (ORCPT ); Fri, 3 Jun 2022 13:01:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243045AbiFCRBI (ORCPT ); Fri, 3 Jun 2022 13:01:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFC07522D8; Fri, 3 Jun 2022 10:01:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7D2CB61A36; Fri, 3 Jun 2022 17:01:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A025C385A9; Fri, 3 Jun 2022 17:01:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654275666; bh=RSQ8NkpnOkmzm6/aUP8DpyGlnoqBYtHZOvzZFrlSehs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Pr7p+ki4uN5VzCRliCrBcm2J5wlHvJIcbX83rjlBZbFcnZRpQ0wn5aqLk2IVQ7XTr A4XFHNrZjvtcsIfyIjdKL4nEujpPosu9Ne8rsGecdfnm32FUyxwNkKcChqJP9MIUYQ uqMDUPyNyhBGxbmmxl8+R4OVohvaaEtImdZjmQ8ZU2c0ZRpZrNBa49jqR9824Lawsa 4pylqIseZNCNjoXSx+52+EoexjpnHn/xNNcGLZR0YpNC0AvthI0fq6ECD54b97iB5q LLmYlHsuzv02vt/H8hFrpoWDpwqbnsLo6j9GxJsV5E4NYHgEKSSrCqW79BtBZbZcRo cdm6s+8/BTleA== Date: Fri, 3 Jun 2022 18:10:06 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lars-Peter Clausen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Subject: Re: [PATCH v1 1/1] iio: adc: mxs-lradc-adc: Get rid of OF specifics Message-ID: <20220603181006.2c5cc6c4@jic23-huawei> In-Reply-To: <20220530173324.921-1-andriy.shevchenko@linux.intel.com> References: <20220530173324.921-1-andriy.shevchenko@linux.intel.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 30 May 2022 20:33:24 +0300 Andy Shevchenko wrote: > First of all, the additional conversion from vIRQ, and this is exactly > what is returned by platform_get_irq_byname(), to vIRQ is not needed. Confusing sentence form. Perhaps: First, the additional conversion from vIRQ (returned by platform_get_irq_byname()) to vIRQ is not needed. > Hence, drop no-op call to irq_of_parse_and_map(). > > Second, assign the firmware node instead of of_node. > > Signed-off-by: Andy Shevchenko Hi, Seems sensible to me, but I'd like a sanity check from someone more familiar with this driver. Thanks, Jonathan > --- > drivers/iio/adc/mxs-lradc-adc.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/iio/adc/mxs-lradc-adc.c b/drivers/iio/adc/mxs-lradc-adc.c > index bca79a93cbe4..25292bb8a13f 100644 > --- a/drivers/iio/adc/mxs-lradc-adc.c > +++ b/drivers/iio/adc/mxs-lradc-adc.c > @@ -17,7 +17,6 @@ > #include > #include > #include > -#include > #include > #include > > @@ -692,7 +691,7 @@ static int mxs_lradc_adc_probe(struct platform_device *pdev) > struct mxs_lradc_adc *adc; > struct iio_dev *iio; > struct resource *iores; > - int ret, irq, virq, i, s, n; > + int ret, irq, i, s, n; > u64 scale_uv; > const char **irq_name; > > @@ -721,7 +720,7 @@ static int mxs_lradc_adc_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, iio); > > iio->name = pdev->name; > - iio->dev.of_node = dev->parent->of_node; > + device_set_node(&iio->dev, dev_fwnode(dev->parent)); > iio->info = &mxs_lradc_adc_iio_info; > iio->modes = INDIO_DIRECT_MODE; > iio->masklength = LRADC_MAX_TOTAL_CHANS; > @@ -747,9 +746,7 @@ static int mxs_lradc_adc_probe(struct platform_device *pdev) > if (irq < 0) > return irq; > > - virq = irq_of_parse_and_map(dev->parent->of_node, irq); > - > - ret = devm_request_irq(dev, virq, mxs_lradc_adc_handle_irq, > + ret = devm_request_irq(dev, irq, mxs_lradc_adc_handle_irq, > 0, irq_name[i], iio); > if (ret) > return ret;