* [PATCH v2 1/4] iio: imu: bmi160: Move exported symbols to IIO_BMI160 namespace
2022-06-04 15:53 [PATCH v2 0/4] 3rd set of IIO export namespaces Jonathan Cameron
@ 2022-06-04 15:53 ` Jonathan Cameron
2022-06-04 15:53 ` [PATCH v2 2/4] iio: pressure: bmp280: Move symbol exports to IIO_BMP280 namespace Jonathan Cameron
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Jonathan Cameron @ 2022-06-04 15:53 UTC (permalink / raw)
To: linux-iio; +Cc: Jonathan Cameron
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Avoid unnecessary pollution of the global symbol namespace by
moving library functions in to a specific namespace and import
that into the drivers that make use of the functions.
For more info: https://lwn.net/Articles/760045/
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20220220173701.502331-2-jic23@kernel.org
---
drivers/iio/imu/bmi160/bmi160_core.c | 6 +++---
drivers/iio/imu/bmi160/bmi160_i2c.c | 1 +
drivers/iio/imu/bmi160/bmi160_spi.c | 1 +
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/imu/bmi160/bmi160_core.c b/drivers/iio/imu/bmi160/bmi160_core.c
index e7aec56ea136..a77f1a8348ff 100644
--- a/drivers/iio/imu/bmi160/bmi160_core.c
+++ b/drivers/iio/imu/bmi160/bmi160_core.c
@@ -143,7 +143,7 @@ const struct regmap_config bmi160_regmap_config = {
.reg_bits = 8,
.val_bits = 8,
};
-EXPORT_SYMBOL(bmi160_regmap_config);
+EXPORT_SYMBOL_NS(bmi160_regmap_config, IIO_BMI160);
struct bmi160_regs {
u8 data; /* LSB byte register for X-axis */
@@ -633,7 +633,7 @@ int bmi160_enable_irq(struct regmap *regmap, bool enable)
BMI160_DRDY_INT_EN, enable_bit,
BMI160_NORMAL_WRITE_USLEEP);
}
-EXPORT_SYMBOL(bmi160_enable_irq);
+EXPORT_SYMBOL_NS(bmi160_enable_irq, IIO_BMI160);
static int bmi160_get_irq(struct fwnode_handle *fwnode, enum bmi160_int_pin *pin)
{
@@ -884,7 +884,7 @@ int bmi160_core_probe(struct device *dev, struct regmap *regmap,
return devm_iio_device_register(dev, indio_dev);
}
-EXPORT_SYMBOL_GPL(bmi160_core_probe);
+EXPORT_SYMBOL_NS_GPL(bmi160_core_probe, IIO_BMI160);
MODULE_AUTHOR("Daniel Baluta <daniel.baluta@intel.com>");
MODULE_DESCRIPTION("Bosch BMI160 driver");
diff --git a/drivers/iio/imu/bmi160/bmi160_i2c.c b/drivers/iio/imu/bmi160/bmi160_i2c.c
index 02f149d37b17..d93f4fa2ad55 100644
--- a/drivers/iio/imu/bmi160/bmi160_i2c.c
+++ b/drivers/iio/imu/bmi160/bmi160_i2c.c
@@ -68,3 +68,4 @@ module_i2c_driver(bmi160_i2c_driver);
MODULE_AUTHOR("Daniel Baluta <daniel.baluta@intel.com>");
MODULE_DESCRIPTION("BMI160 I2C driver");
MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(IIO_BMI160);
diff --git a/drivers/iio/imu/bmi160/bmi160_spi.c b/drivers/iio/imu/bmi160/bmi160_spi.c
index 24f7d75c7903..8b573ea99af2 100644
--- a/drivers/iio/imu/bmi160/bmi160_spi.c
+++ b/drivers/iio/imu/bmi160/bmi160_spi.c
@@ -65,3 +65,4 @@ module_spi_driver(bmi160_spi_driver);
MODULE_AUTHOR("Daniel Baluta <daniel.baluta@intel.com");
MODULE_DESCRIPTION("Bosch BMI160 SPI driver");
MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(IIO_BMI160);
--
2.36.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2 2/4] iio: pressure: bmp280: Move symbol exports to IIO_BMP280 namespace
2022-06-04 15:53 [PATCH v2 0/4] 3rd set of IIO export namespaces Jonathan Cameron
2022-06-04 15:53 ` [PATCH v2 1/4] iio: imu: bmi160: Move exported symbols to IIO_BMI160 namespace Jonathan Cameron
@ 2022-06-04 15:53 ` Jonathan Cameron
2022-06-04 15:53 ` [PATCH v2 3/4] iio: chemical: sps30: Move symbol exports into IIO_SPS30 namespace Jonathan Cameron
` (2 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Jonathan Cameron @ 2022-06-04 15:53 UTC (permalink / raw)
To: linux-iio; +Cc: Jonathan Cameron
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Avoid unnecessary pollution of the global symbol namespace by
moving library functions in to a specific namespace and import
that into the drivers that make use of the functions.
For more info: https://lwn.net/Articles/760045/
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20220220173701.502331-3-jic23@kernel.org
---
drivers/iio/pressure/bmp280-core.c | 2 +-
drivers/iio/pressure/bmp280-i2c.c | 1 +
drivers/iio/pressure/bmp280-regmap.c | 4 ++--
drivers/iio/pressure/bmp280-spi.c | 1 +
4 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c
index bf8167f43c56..fe7aa81e7cc9 100644
--- a/drivers/iio/pressure/bmp280-core.c
+++ b/drivers/iio/pressure/bmp280-core.c
@@ -1136,7 +1136,7 @@ int bmp280_common_probe(struct device *dev,
return devm_iio_device_register(dev, indio_dev);
}
-EXPORT_SYMBOL(bmp280_common_probe);
+EXPORT_SYMBOL_NS(bmp280_common_probe, IIO_BMP280);
static int bmp280_runtime_suspend(struct device *dev)
{
diff --git a/drivers/iio/pressure/bmp280-i2c.c b/drivers/iio/pressure/bmp280-i2c.c
index 35045bd92846..bf4a7a617537 100644
--- a/drivers/iio/pressure/bmp280-i2c.c
+++ b/drivers/iio/pressure/bmp280-i2c.c
@@ -68,3 +68,4 @@ module_i2c_driver(bmp280_i2c_driver);
MODULE_AUTHOR("Vlad Dogaru <vlad.dogaru@intel.com>");
MODULE_DESCRIPTION("Driver for Bosch Sensortec BMP180/BMP280 pressure and temperature sensor");
MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(IIO_BMP280);
diff --git a/drivers/iio/pressure/bmp280-regmap.c b/drivers/iio/pressure/bmp280-regmap.c
index da136dbadc8f..969698518984 100644
--- a/drivers/iio/pressure/bmp280-regmap.c
+++ b/drivers/iio/pressure/bmp280-regmap.c
@@ -39,7 +39,7 @@ const struct regmap_config bmp180_regmap_config = {
.writeable_reg = bmp180_is_writeable_reg,
.volatile_reg = bmp180_is_volatile_reg,
};
-EXPORT_SYMBOL(bmp180_regmap_config);
+EXPORT_SYMBOL_NS(bmp180_regmap_config, IIO_BMP280);
static bool bmp280_is_writeable_reg(struct device *dev, unsigned int reg)
{
@@ -82,4 +82,4 @@ const struct regmap_config bmp280_regmap_config = {
.writeable_reg = bmp280_is_writeable_reg,
.volatile_reg = bmp280_is_volatile_reg,
};
-EXPORT_SYMBOL(bmp280_regmap_config);
+EXPORT_SYMBOL_NS(bmp280_regmap_config, IIO_BMP280);
diff --git a/drivers/iio/pressure/bmp280-spi.c b/drivers/iio/pressure/bmp280-spi.c
index 41f6cc56d229..4cfaf3e869b8 100644
--- a/drivers/iio/pressure/bmp280-spi.c
+++ b/drivers/iio/pressure/bmp280-spi.c
@@ -118,3 +118,4 @@ module_spi_driver(bmp280_spi_driver);
MODULE_DESCRIPTION("BMP280 SPI bus driver");
MODULE_LICENSE("GPL");
+MODULE_IMPORT_NS(IIO_BMP280);
--
2.36.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2 3/4] iio: chemical: sps30: Move symbol exports into IIO_SPS30 namespace
2022-06-04 15:53 [PATCH v2 0/4] 3rd set of IIO export namespaces Jonathan Cameron
2022-06-04 15:53 ` [PATCH v2 1/4] iio: imu: bmi160: Move exported symbols to IIO_BMI160 namespace Jonathan Cameron
2022-06-04 15:53 ` [PATCH v2 2/4] iio: pressure: bmp280: Move symbol exports to IIO_BMP280 namespace Jonathan Cameron
@ 2022-06-04 15:53 ` Jonathan Cameron
2022-06-04 15:53 ` [PATCH v2 4/4] iio: adc: qcom-vadc: Move symbol exports to IIO_QCOM_VADC namespace Jonathan Cameron
2022-06-18 13:20 ` [PATCH v2 0/4] 3rd set of IIO export namespaces Jonathan Cameron
4 siblings, 0 replies; 9+ messages in thread
From: Jonathan Cameron @ 2022-06-04 15:53 UTC (permalink / raw)
To: linux-iio; +Cc: Jonathan Cameron, Tomasz Duszynski
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Avoid unnecessary pollution of the global symbol namespace by
moving library functions in to a specific namespace and import
that into the drivers that make use of the functions.
For more info: https://lwn.net/Articles/760045/
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Tomasz Duszynski <tomasz.duszynski@octakon.com>
Link: https://lore.kernel.org/r/20220220173701.502331-4-jic23@kernel.org
---
drivers/iio/chemical/sps30.c | 2 +-
drivers/iio/chemical/sps30_i2c.c | 1 +
drivers/iio/chemical/sps30_serial.c | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/chemical/sps30.c b/drivers/iio/chemical/sps30.c
index abd67559e451..814ce0aad1cc 100644
--- a/drivers/iio/chemical/sps30.c
+++ b/drivers/iio/chemical/sps30.c
@@ -372,7 +372,7 @@ int sps30_probe(struct device *dev, const char *name, void *priv, const struct s
return devm_iio_device_register(dev, indio_dev);
}
-EXPORT_SYMBOL_GPL(sps30_probe);
+EXPORT_SYMBOL_NS_GPL(sps30_probe, IIO_SPS30);
MODULE_AUTHOR("Tomasz Duszynski <tduszyns@gmail.com>");
MODULE_DESCRIPTION("Sensirion SPS30 particulate matter sensor driver");
diff --git a/drivers/iio/chemical/sps30_i2c.c b/drivers/iio/chemical/sps30_i2c.c
index d33560ed7184..2aed483a2fde 100644
--- a/drivers/iio/chemical/sps30_i2c.c
+++ b/drivers/iio/chemical/sps30_i2c.c
@@ -256,3 +256,4 @@ module_i2c_driver(sps30_i2c_driver);
MODULE_AUTHOR("Tomasz Duszynski <tomasz.duszynski@octakon.com>");
MODULE_DESCRIPTION("Sensirion SPS30 particulate matter sensor i2c driver");
MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(IIO_SPS30);
diff --git a/drivers/iio/chemical/sps30_serial.c b/drivers/iio/chemical/sps30_serial.c
index 3f311d50087c..164f4b3e025c 100644
--- a/drivers/iio/chemical/sps30_serial.c
+++ b/drivers/iio/chemical/sps30_serial.c
@@ -429,3 +429,4 @@ module_serdev_device_driver(sps30_serial_driver);
MODULE_AUTHOR("Tomasz Duszynski <tomasz.duszynski@octakon.com>");
MODULE_DESCRIPTION("Sensirion SPS30 particulate matter sensor serial driver");
MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(IIO_SPS30);
--
2.36.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2 4/4] iio: adc: qcom-vadc: Move symbol exports to IIO_QCOM_VADC namespace
2022-06-04 15:53 [PATCH v2 0/4] 3rd set of IIO export namespaces Jonathan Cameron
` (2 preceding siblings ...)
2022-06-04 15:53 ` [PATCH v2 3/4] iio: chemical: sps30: Move symbol exports into IIO_SPS30 namespace Jonathan Cameron
@ 2022-06-04 15:53 ` Jonathan Cameron
2022-07-01 10:15 ` Jonathan Cameron
2022-06-18 13:20 ` [PATCH v2 0/4] 3rd set of IIO export namespaces Jonathan Cameron
4 siblings, 1 reply; 9+ messages in thread
From: Jonathan Cameron @ 2022-06-04 15:53 UTC (permalink / raw)
To: linux-iio; +Cc: Jonathan Cameron, Dmitry Baryshkov, Siddartha Mohanadoss
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Avoid unnecessary pollution of the global symbol namespace by
moving library functions in to a specific namespace and import
that into the drivers that make use of the functions.
For more info: https://lwn.net/Articles/760045/
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Siddartha Mohanadoss <smohanad@codeaurora.org>
Link: https://lore.kernel.org/r/20220220173701.502331-6-jic23@kernel.org
---
drivers/iio/adc/qcom-pm8xxx-xoadc.c | 1 +
drivers/iio/adc/qcom-spmi-adc5.c | 1 +
drivers/iio/adc/qcom-spmi-vadc.c | 1 +
drivers/iio/adc/qcom-vadc-common.c | 16 ++++++++--------
4 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/iio/adc/qcom-pm8xxx-xoadc.c b/drivers/iio/adc/qcom-pm8xxx-xoadc.c
index 5e9e56821075..e2ef89dcaa5e 100644
--- a/drivers/iio/adc/qcom-pm8xxx-xoadc.c
+++ b/drivers/iio/adc/qcom-pm8xxx-xoadc.c
@@ -1028,3 +1028,4 @@ module_platform_driver(pm8xxx_xoadc_driver);
MODULE_DESCRIPTION("PM8xxx XOADC driver");
MODULE_LICENSE("GPL v2");
MODULE_ALIAS("platform:pm8xxx-xoadc");
+MODULE_IMPORT_NS(IIO_QCOM_VADC);
diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b/drivers/iio/adc/qcom-spmi-adc5.c
index 87438d1e5c0b..10bb51b648c1 100644
--- a/drivers/iio/adc/qcom-spmi-adc5.c
+++ b/drivers/iio/adc/qcom-spmi-adc5.c
@@ -925,3 +925,4 @@ module_platform_driver(adc5_driver);
MODULE_ALIAS("platform:qcom-spmi-adc5");
MODULE_DESCRIPTION("Qualcomm Technologies Inc. PMIC5 ADC driver");
MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(IIO_QCOM_VADC);
diff --git a/drivers/iio/adc/qcom-spmi-vadc.c b/drivers/iio/adc/qcom-spmi-vadc.c
index 34202ba52469..cb0c6af091ac 100644
--- a/drivers/iio/adc/qcom-spmi-vadc.c
+++ b/drivers/iio/adc/qcom-spmi-vadc.c
@@ -935,3 +935,4 @@ MODULE_DESCRIPTION("Qualcomm SPMI PMIC voltage ADC driver");
MODULE_LICENSE("GPL v2");
MODULE_AUTHOR("Stanimir Varbanov <svarbanov@mm-sol.com>");
MODULE_AUTHOR("Ivan T. Ivanov <iivanov@mm-sol.com>");
+MODULE_IMPORT_NS(IIO_QCOM_VADC);
diff --git a/drivers/iio/adc/qcom-vadc-common.c b/drivers/iio/adc/qcom-vadc-common.c
index d5209f32adb3..7ca191ea1a65 100644
--- a/drivers/iio/adc/qcom-vadc-common.c
+++ b/drivers/iio/adc/qcom-vadc-common.c
@@ -662,7 +662,7 @@ int qcom_vadc_scale(enum vadc_scale_fn_type scaletype,
return -EINVAL;
}
}
-EXPORT_SYMBOL(qcom_vadc_scale);
+EXPORT_SYMBOL_NS(qcom_vadc_scale, IIO_QCOM_VADC);
u16 qcom_adc_tm5_temp_volt_scale(unsigned int prescale_ratio,
u32 full_scale_code_volt, int temp)
@@ -675,7 +675,7 @@ u16 qcom_adc_tm5_temp_volt_scale(unsigned int prescale_ratio,
temp);
return qcom_vadc_scale_voltage_code(voltage, prescale, full_scale_code_volt, 1000);
}
-EXPORT_SYMBOL(qcom_adc_tm5_temp_volt_scale);
+EXPORT_SYMBOL_NS(qcom_adc_tm5_temp_volt_scale, IIO_QCOM_VADC);
u16 qcom_adc_tm5_gen2_temp_res_scale(int temp)
{
@@ -704,7 +704,7 @@ int qcom_adc5_hw_scale(enum vadc_scale_fn_type scaletype,
return scale_adc5_fn[scaletype].scale_fn(prescale, data,
adc_code, result);
}
-EXPORT_SYMBOL(qcom_adc5_hw_scale);
+EXPORT_SYMBOL_NS(qcom_adc5_hw_scale, IIO_QCOM_VADC);
int qcom_adc5_prescaling_from_dt(u32 numerator, u32 denominator)
{
@@ -720,7 +720,7 @@ int qcom_adc5_prescaling_from_dt(u32 numerator, u32 denominator)
return pre;
}
-EXPORT_SYMBOL(qcom_adc5_prescaling_from_dt);
+EXPORT_SYMBOL_NS(qcom_adc5_prescaling_from_dt, IIO_QCOM_VADC);
int qcom_adc5_hw_settle_time_from_dt(u32 value,
const unsigned int *hw_settle)
@@ -734,7 +734,7 @@ int qcom_adc5_hw_settle_time_from_dt(u32 value,
return -EINVAL;
}
-EXPORT_SYMBOL(qcom_adc5_hw_settle_time_from_dt);
+EXPORT_SYMBOL_NS(qcom_adc5_hw_settle_time_from_dt, IIO_QCOM_VADC);
int qcom_adc5_avg_samples_from_dt(u32 value)
{
@@ -743,7 +743,7 @@ int qcom_adc5_avg_samples_from_dt(u32 value)
return __ffs(value);
}
-EXPORT_SYMBOL(qcom_adc5_avg_samples_from_dt);
+EXPORT_SYMBOL_NS(qcom_adc5_avg_samples_from_dt, IIO_QCOM_VADC);
int qcom_adc5_decimation_from_dt(u32 value, const unsigned int *decimation)
{
@@ -756,7 +756,7 @@ int qcom_adc5_decimation_from_dt(u32 value, const unsigned int *decimation)
return -EINVAL;
}
-EXPORT_SYMBOL(qcom_adc5_decimation_from_dt);
+EXPORT_SYMBOL_NS(qcom_adc5_decimation_from_dt, IIO_QCOM_VADC);
int qcom_vadc_decimation_from_dt(u32 value)
{
@@ -766,7 +766,7 @@ int qcom_vadc_decimation_from_dt(u32 value)
return __ffs64(value / VADC_DECIMATION_MIN);
}
-EXPORT_SYMBOL(qcom_vadc_decimation_from_dt);
+EXPORT_SYMBOL_NS(qcom_vadc_decimation_from_dt, IIO_QCOM_VADC);
MODULE_LICENSE("GPL v2");
MODULE_DESCRIPTION("Qualcomm ADC common functionality");
--
2.36.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2 4/4] iio: adc: qcom-vadc: Move symbol exports to IIO_QCOM_VADC namespace
2022-06-04 15:53 ` [PATCH v2 4/4] iio: adc: qcom-vadc: Move symbol exports to IIO_QCOM_VADC namespace Jonathan Cameron
@ 2022-07-01 10:15 ` Jonathan Cameron
0 siblings, 0 replies; 9+ messages in thread
From: Jonathan Cameron @ 2022-07-01 10:15 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: linux-iio, Dmitry Baryshkov, Siddartha Mohanadoss
On Sat, 4 Jun 2022 16:53:06 +0100
Jonathan Cameron <jic23@kernel.org> wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Avoid unnecessary pollution of the global symbol namespace by
> moving library functions in to a specific namespace and import
> that into the drivers that make use of the functions.
>
> For more info: https://lwn.net/Articles/760045/
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Cc: Siddartha Mohanadoss <smohanad@codeaurora.org>
> Link: https://lore.kernel.org/r/20220220173701.502331-6-jic23@kernel.org
Dropped for now after a build issue found in linux next as
there are a few calls into this made from a thermal driver.
I'll send out a new version at somepoint.
Thanks,
Jonathan
> ---
> drivers/iio/adc/qcom-pm8xxx-xoadc.c | 1 +
> drivers/iio/adc/qcom-spmi-adc5.c | 1 +
> drivers/iio/adc/qcom-spmi-vadc.c | 1 +
> drivers/iio/adc/qcom-vadc-common.c | 16 ++++++++--------
> 4 files changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/iio/adc/qcom-pm8xxx-xoadc.c b/drivers/iio/adc/qcom-pm8xxx-xoadc.c
> index 5e9e56821075..e2ef89dcaa5e 100644
> --- a/drivers/iio/adc/qcom-pm8xxx-xoadc.c
> +++ b/drivers/iio/adc/qcom-pm8xxx-xoadc.c
> @@ -1028,3 +1028,4 @@ module_platform_driver(pm8xxx_xoadc_driver);
> MODULE_DESCRIPTION("PM8xxx XOADC driver");
> MODULE_LICENSE("GPL v2");
> MODULE_ALIAS("platform:pm8xxx-xoadc");
> +MODULE_IMPORT_NS(IIO_QCOM_VADC);
> diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b/drivers/iio/adc/qcom-spmi-adc5.c
> index 87438d1e5c0b..10bb51b648c1 100644
> --- a/drivers/iio/adc/qcom-spmi-adc5.c
> +++ b/drivers/iio/adc/qcom-spmi-adc5.c
> @@ -925,3 +925,4 @@ module_platform_driver(adc5_driver);
> MODULE_ALIAS("platform:qcom-spmi-adc5");
> MODULE_DESCRIPTION("Qualcomm Technologies Inc. PMIC5 ADC driver");
> MODULE_LICENSE("GPL v2");
> +MODULE_IMPORT_NS(IIO_QCOM_VADC);
> diff --git a/drivers/iio/adc/qcom-spmi-vadc.c b/drivers/iio/adc/qcom-spmi-vadc.c
> index 34202ba52469..cb0c6af091ac 100644
> --- a/drivers/iio/adc/qcom-spmi-vadc.c
> +++ b/drivers/iio/adc/qcom-spmi-vadc.c
> @@ -935,3 +935,4 @@ MODULE_DESCRIPTION("Qualcomm SPMI PMIC voltage ADC driver");
> MODULE_LICENSE("GPL v2");
> MODULE_AUTHOR("Stanimir Varbanov <svarbanov@mm-sol.com>");
> MODULE_AUTHOR("Ivan T. Ivanov <iivanov@mm-sol.com>");
> +MODULE_IMPORT_NS(IIO_QCOM_VADC);
> diff --git a/drivers/iio/adc/qcom-vadc-common.c b/drivers/iio/adc/qcom-vadc-common.c
> index d5209f32adb3..7ca191ea1a65 100644
> --- a/drivers/iio/adc/qcom-vadc-common.c
> +++ b/drivers/iio/adc/qcom-vadc-common.c
> @@ -662,7 +662,7 @@ int qcom_vadc_scale(enum vadc_scale_fn_type scaletype,
> return -EINVAL;
> }
> }
> -EXPORT_SYMBOL(qcom_vadc_scale);
> +EXPORT_SYMBOL_NS(qcom_vadc_scale, IIO_QCOM_VADC);
>
> u16 qcom_adc_tm5_temp_volt_scale(unsigned int prescale_ratio,
> u32 full_scale_code_volt, int temp)
> @@ -675,7 +675,7 @@ u16 qcom_adc_tm5_temp_volt_scale(unsigned int prescale_ratio,
> temp);
> return qcom_vadc_scale_voltage_code(voltage, prescale, full_scale_code_volt, 1000);
> }
> -EXPORT_SYMBOL(qcom_adc_tm5_temp_volt_scale);
> +EXPORT_SYMBOL_NS(qcom_adc_tm5_temp_volt_scale, IIO_QCOM_VADC);
>
> u16 qcom_adc_tm5_gen2_temp_res_scale(int temp)
> {
> @@ -704,7 +704,7 @@ int qcom_adc5_hw_scale(enum vadc_scale_fn_type scaletype,
> return scale_adc5_fn[scaletype].scale_fn(prescale, data,
> adc_code, result);
> }
> -EXPORT_SYMBOL(qcom_adc5_hw_scale);
> +EXPORT_SYMBOL_NS(qcom_adc5_hw_scale, IIO_QCOM_VADC);
>
> int qcom_adc5_prescaling_from_dt(u32 numerator, u32 denominator)
> {
> @@ -720,7 +720,7 @@ int qcom_adc5_prescaling_from_dt(u32 numerator, u32 denominator)
>
> return pre;
> }
> -EXPORT_SYMBOL(qcom_adc5_prescaling_from_dt);
> +EXPORT_SYMBOL_NS(qcom_adc5_prescaling_from_dt, IIO_QCOM_VADC);
>
> int qcom_adc5_hw_settle_time_from_dt(u32 value,
> const unsigned int *hw_settle)
> @@ -734,7 +734,7 @@ int qcom_adc5_hw_settle_time_from_dt(u32 value,
>
> return -EINVAL;
> }
> -EXPORT_SYMBOL(qcom_adc5_hw_settle_time_from_dt);
> +EXPORT_SYMBOL_NS(qcom_adc5_hw_settle_time_from_dt, IIO_QCOM_VADC);
>
> int qcom_adc5_avg_samples_from_dt(u32 value)
> {
> @@ -743,7 +743,7 @@ int qcom_adc5_avg_samples_from_dt(u32 value)
>
> return __ffs(value);
> }
> -EXPORT_SYMBOL(qcom_adc5_avg_samples_from_dt);
> +EXPORT_SYMBOL_NS(qcom_adc5_avg_samples_from_dt, IIO_QCOM_VADC);
>
> int qcom_adc5_decimation_from_dt(u32 value, const unsigned int *decimation)
> {
> @@ -756,7 +756,7 @@ int qcom_adc5_decimation_from_dt(u32 value, const unsigned int *decimation)
>
> return -EINVAL;
> }
> -EXPORT_SYMBOL(qcom_adc5_decimation_from_dt);
> +EXPORT_SYMBOL_NS(qcom_adc5_decimation_from_dt, IIO_QCOM_VADC);
>
> int qcom_vadc_decimation_from_dt(u32 value)
> {
> @@ -766,7 +766,7 @@ int qcom_vadc_decimation_from_dt(u32 value)
>
> return __ffs64(value / VADC_DECIMATION_MIN);
> }
> -EXPORT_SYMBOL(qcom_vadc_decimation_from_dt);
> +EXPORT_SYMBOL_NS(qcom_vadc_decimation_from_dt, IIO_QCOM_VADC);
>
> MODULE_LICENSE("GPL v2");
> MODULE_DESCRIPTION("Qualcomm ADC common functionality");
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/4] 3rd set of IIO export namespaces.
2022-06-04 15:53 [PATCH v2 0/4] 3rd set of IIO export namespaces Jonathan Cameron
` (3 preceding siblings ...)
2022-06-04 15:53 ` [PATCH v2 4/4] iio: adc: qcom-vadc: Move symbol exports to IIO_QCOM_VADC namespace Jonathan Cameron
@ 2022-06-18 13:20 ` Jonathan Cameron
2022-06-21 3:37 ` Joe Simmons-Talbott
4 siblings, 1 reply; 9+ messages in thread
From: Jonathan Cameron @ 2022-06-18 13:20 UTC (permalink / raw)
To: linux-iio
Cc: Jonathan Cameron, Tomasz Duszynski, Nuno Sá,
Dmitry Baryshkov, Siddartha Mohanadoss
On Sat, 4 Jun 2022 16:53:02 +0100
Jonathan Cameron <jic23@kernel.org> wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Changes since v1:
> - Rebase (bit of fuzz in patches 1 and 4)
If anyone has time to take a quick look through this lot and sanity
check I haven't done anything stupid it would be much appreciated.
Disadvantage of being the maintainer is there isn't anyone else you
can moan about when no one reviews your patches. Of course I never
moan about other maintainers and I'm sure no one ever moans
about me :)
>
> I sent v1 out in Feb and only got review on one patch (which I've since
> applied - thanks Nuno).
>
> Looking for a quick sanity check of these 4 that remain from anyone who
> has the time. Whilst this is mechanical stuff, I've made enough dumb
> mistakes in such patches over the years that I still like to get a second
> set of eyes on them if at all possible!
>
> Cc: Tomasz Duszynski <tomasz.duszynski@octakon.com>
> Cc: Nuno Sá <nuno.sa@analog.com>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Cc: Siddartha Mohanadoss <smohanad@codeaurora.org>
>
> Jonathan Cameron (4):
> iio: imu: bmi160: Move exported symbols to IIO_BMI160 namespace
> iio: pressure: bmp280: Move symbol exports to IIO_BMP280 namespace
> iio: chemical: sps30: Move symbol exports into IIO_SPS30 namespace
> iio: adc: qcom-vadc: Move symbol exports to IIO_QCOM_VADC namespace
>
> drivers/iio/adc/qcom-pm8xxx-xoadc.c | 1 +
> drivers/iio/adc/qcom-spmi-adc5.c | 1 +
> drivers/iio/adc/qcom-spmi-vadc.c | 1 +
> drivers/iio/adc/qcom-vadc-common.c | 16 ++++++++--------
> drivers/iio/chemical/sps30.c | 2 +-
> drivers/iio/chemical/sps30_i2c.c | 1 +
> drivers/iio/chemical/sps30_serial.c | 1 +
> drivers/iio/imu/bmi160/bmi160_core.c | 6 +++---
> drivers/iio/imu/bmi160/bmi160_i2c.c | 1 +
> drivers/iio/imu/bmi160/bmi160_spi.c | 1 +
> drivers/iio/pressure/bmp280-core.c | 2 +-
> drivers/iio/pressure/bmp280-i2c.c | 1 +
> drivers/iio/pressure/bmp280-regmap.c | 4 ++--
> drivers/iio/pressure/bmp280-spi.c | 1 +
> 14 files changed, 24 insertions(+), 15 deletions(-)
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2 0/4] 3rd set of IIO export namespaces.
2022-06-18 13:20 ` [PATCH v2 0/4] 3rd set of IIO export namespaces Jonathan Cameron
@ 2022-06-21 3:37 ` Joe Simmons-Talbott
2022-06-21 20:31 ` Jonathan Cameron
0 siblings, 1 reply; 9+ messages in thread
From: Joe Simmons-Talbott @ 2022-06-21 3:37 UTC (permalink / raw)
To: Jonathan Cameron
Cc: linux-iio, Jonathan Cameron, Tomasz Duszynski, Nuno Sá,
Dmitry Baryshkov, Siddartha Mohanadoss
On Sat, Jun 18, 2022 at 02:20:54PM +0100, Jonathan Cameron wrote:
> On Sat, 4 Jun 2022 16:53:02 +0100
> Jonathan Cameron <jic23@kernel.org> wrote:
>
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Changes since v1:
> > - Rebase (bit of fuzz in patches 1 and 4)
>
> If anyone has time to take a quick look through this lot and sanity
> check I haven't done anything stupid it would be much appreciated.
FWIW, 1 through 4 look good to me.
Reviewed-By: Joe Simmons-Talbott <joetalbott@gmail.com>
Joe
>
> Disadvantage of being the maintainer is there isn't anyone else you
> can moan about when no one reviews your patches. Of course I never
> moan about other maintainers and I'm sure no one ever moans
> about me :)
>
> >
> > I sent v1 out in Feb and only got review on one patch (which I've since
> > applied - thanks Nuno).
> >
> > Looking for a quick sanity check of these 4 that remain from anyone who
> > has the time. Whilst this is mechanical stuff, I've made enough dumb
> > mistakes in such patches over the years that I still like to get a second
> > set of eyes on them if at all possible!
> >
> > Cc: Tomasz Duszynski <tomasz.duszynski@octakon.com>
> > Cc: Nuno Sá <nuno.sa@analog.com>
> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > Cc: Siddartha Mohanadoss <smohanad@codeaurora.org>
> >
> > Jonathan Cameron (4):
> > iio: imu: bmi160: Move exported symbols to IIO_BMI160 namespace
> > iio: pressure: bmp280: Move symbol exports to IIO_BMP280 namespace
> > iio: chemical: sps30: Move symbol exports into IIO_SPS30 namespace
> > iio: adc: qcom-vadc: Move symbol exports to IIO_QCOM_VADC namespace
> >
> > drivers/iio/adc/qcom-pm8xxx-xoadc.c | 1 +
> > drivers/iio/adc/qcom-spmi-adc5.c | 1 +
> > drivers/iio/adc/qcom-spmi-vadc.c | 1 +
> > drivers/iio/adc/qcom-vadc-common.c | 16 ++++++++--------
> > drivers/iio/chemical/sps30.c | 2 +-
> > drivers/iio/chemical/sps30_i2c.c | 1 +
> > drivers/iio/chemical/sps30_serial.c | 1 +
> > drivers/iio/imu/bmi160/bmi160_core.c | 6 +++---
> > drivers/iio/imu/bmi160/bmi160_i2c.c | 1 +
> > drivers/iio/imu/bmi160/bmi160_spi.c | 1 +
> > drivers/iio/pressure/bmp280-core.c | 2 +-
> > drivers/iio/pressure/bmp280-i2c.c | 1 +
> > drivers/iio/pressure/bmp280-regmap.c | 4 ++--
> > drivers/iio/pressure/bmp280-spi.c | 1 +
> > 14 files changed, 24 insertions(+), 15 deletions(-)
> >
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/4] 3rd set of IIO export namespaces.
2022-06-21 3:37 ` Joe Simmons-Talbott
@ 2022-06-21 20:31 ` Jonathan Cameron
0 siblings, 0 replies; 9+ messages in thread
From: Jonathan Cameron @ 2022-06-21 20:31 UTC (permalink / raw)
To: Joe Simmons-Talbott
Cc: linux-iio, Jonathan Cameron, Tomasz Duszynski, Nuno Sá,
Dmitry Baryshkov, Siddartha Mohanadoss
On Mon, 20 Jun 2022 23:37:22 -0400
Joe Simmons-Talbott <joetalbott@gmail.com> wrote:
> On Sat, Jun 18, 2022 at 02:20:54PM +0100, Jonathan Cameron wrote:
> > On Sat, 4 Jun 2022 16:53:02 +0100
> > Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > >
> > > Changes since v1:
> > > - Rebase (bit of fuzz in patches 1 and 4)
> >
> > If anyone has time to take a quick look through this lot and sanity
> > check I haven't done anything stupid it would be much appreciated.
>
> FWIW, 1 through 4 look good to me.
>
> Reviewed-By: Joe Simmons-Talbott <joetalbott@gmail.com>
>
Thanks!
Applied to the togreg branch of iio.git and pushed out as testing to
see if 0-day finds anything we missed.
Thanks,
Jonathan
> Joe
> >
> > Disadvantage of being the maintainer is there isn't anyone else you
> > can moan about when no one reviews your patches. Of course I never
> > moan about other maintainers and I'm sure no one ever moans
> > about me :)
> >
> > >
> > > I sent v1 out in Feb and only got review on one patch (which I've since
> > > applied - thanks Nuno).
> > >
> > > Looking for a quick sanity check of these 4 that remain from anyone who
> > > has the time. Whilst this is mechanical stuff, I've made enough dumb
> > > mistakes in such patches over the years that I still like to get a second
> > > set of eyes on them if at all possible!
> > >
> > > Cc: Tomasz Duszynski <tomasz.duszynski@octakon.com>
> > > Cc: Nuno Sá <nuno.sa@analog.com>
> > > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > > Cc: Siddartha Mohanadoss <smohanad@codeaurora.org>
> > >
> > > Jonathan Cameron (4):
> > > iio: imu: bmi160: Move exported symbols to IIO_BMI160 namespace
> > > iio: pressure: bmp280: Move symbol exports to IIO_BMP280 namespace
> > > iio: chemical: sps30: Move symbol exports into IIO_SPS30 namespace
> > > iio: adc: qcom-vadc: Move symbol exports to IIO_QCOM_VADC namespace
> > >
> > > drivers/iio/adc/qcom-pm8xxx-xoadc.c | 1 +
> > > drivers/iio/adc/qcom-spmi-adc5.c | 1 +
> > > drivers/iio/adc/qcom-spmi-vadc.c | 1 +
> > > drivers/iio/adc/qcom-vadc-common.c | 16 ++++++++--------
> > > drivers/iio/chemical/sps30.c | 2 +-
> > > drivers/iio/chemical/sps30_i2c.c | 1 +
> > > drivers/iio/chemical/sps30_serial.c | 1 +
> > > drivers/iio/imu/bmi160/bmi160_core.c | 6 +++---
> > > drivers/iio/imu/bmi160/bmi160_i2c.c | 1 +
> > > drivers/iio/imu/bmi160/bmi160_spi.c | 1 +
> > > drivers/iio/pressure/bmp280-core.c | 2 +-
> > > drivers/iio/pressure/bmp280-i2c.c | 1 +
> > > drivers/iio/pressure/bmp280-regmap.c | 4 ++--
> > > drivers/iio/pressure/bmp280-spi.c | 1 +
> > > 14 files changed, 24 insertions(+), 15 deletions(-)
> > >
> >
^ permalink raw reply [flat|nested] 9+ messages in thread