From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7E6CC433EF for ; Wed, 15 Jun 2022 21:00:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348008AbiFOVAY (ORCPT ); Wed, 15 Jun 2022 17:00:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346052AbiFOVAQ (ORCPT ); Wed, 15 Jun 2022 17:00:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C91FB5523D; Wed, 15 Jun 2022 14:00:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6194361356; Wed, 15 Jun 2022 21:00:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F301BC3411E; Wed, 15 Jun 2022 21:00:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655326814; bh=H/KvdVW+OVA5m+P7Zw9G+q3TtBvXLtLwBl8hRTBS/bA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QxbPbc8tlWgFeYsXMM2ZnM0naobnJYZtq2duTMSpUT095EP3ijtx5nuKABHZdHqcI riEpWjEsb1HpqDB3zhiD8V01PxXhGT7S4o0M2xb+CH4emrPXxw6MDnM4zazkrybu5/ A3ZHL/SpqayY9OCkZQ6EC9+gKzel9dVIVleBqXpAbPfnTn3JRWJsjcDlPutNoZsePz BM1soqK1938U73gjJOE5+Pi3Bx2srKZlll0ot6/NupAUIYbxnU6EQ8wHJwHU5ouyKa nQiuiUBRatc9C7gieka7hSvwHqfHU/0d8ckfQOZMvNc99jIu7/WqHyQtvWs5YAh2yK +R731VOOVpxVA== Date: Wed, 15 Jun 2022 22:09:30 +0100 From: Jonathan Cameron To: "Sa, Nuno" Cc: Andy Shevchenko , Alexandru Ardelean , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Lars-Peter Clausen Subject: Re: [PATCH v1 1/1] iio: adc: intel_mrfld_adc: explicitly add proper header files Message-ID: <20220615220930.710ed42d@jic23-huawei> In-Reply-To: References: <20220615120803.41350-1-andriy.shevchenko@linux.intel.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, 15 Jun 2022 12:15:48 +0000 "Sa, Nuno" wrote: > Hi Andy, >=20 > > -----Original Message----- > > From: Andy Shevchenko > > Sent: Wednesday, June 15, 2022 2:08 PM > > To: Andy Shevchenko ; > > Alexandru Ardelean ; linux- > > iio@vger.kernel.org; linux-kernel@vger.kernel.org > > Cc: Jonathan Cameron ; Lars-Peter Clausen > > > > Subject: [PATCH v1 1/1] iio: adc: intel_mrfld_adc: explicitly add proper > > header files > >=20 > > [External] > >=20 > > Do not trust the fact that iio.h includes of.h which in turn includes > > all the headers we are relying on. > >=20 > > The ultimate goal is to actually drop of.h from iio.h. > >=20 > > Signed-off-by: Andy Shevchenko > > > > --- > >=20 > > Jonathan, this should be squeezed before we remove of.h in iio.h > > I think Nuno somehow missed this =20 >=20 > Yes, I did (compile) tested this on arm and arm64 as I said in the cover. > I guess this one won't be enabled on those archs :). >=20 > I was planning to send this on v2 (I did noticed the kernel test bot > emails) but yeah, this should actually be included with the other > patches before removing of.h from iio. Thanks! >=20 > Reviewed-by: Nuno S=C3=A1 Applied. Oddly didn't show up in my normal x86 build test. As suggested, slotted in before the of.h removal patch. Thanks, Jonathan >=20