From: Jonathan Cameron <jic23@kernel.org>
To: Shreeya Patel <shreeya.patel@collabora.com>
Cc: lars@metafoo.de, robh+dt@kernel.org, Zhigang.Shi@liteon.com,
krisman@collabora.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@collabora.com, alvaro.soliverez@collabora.com,
andy.shevchenko@gmail.com, digetx@gmail.com
Subject: Re: [PATCH v6 1/2] dt-bindings: Document ltrf216a light sensor bindings
Date: Sun, 19 Jun 2022 13:34:15 +0100 [thread overview]
Message-ID: <20220619133415.5b3762d3@jic23-huawei> (raw)
In-Reply-To: <20220615135130.227236-2-shreeya.patel@collabora.com>
On Wed, 15 Jun 2022 19:21:29 +0530
Shreeya Patel <shreeya.patel@collabora.com> wrote:
> Add devicetree bindings for ltrf216a ambient light sensor.
>
> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
> ---
> Changes in v5
> - Remove deprecated string 'ltr' from the bindings.
>
> Changes in v3
> - Fix indentation in the example section
>
> Changes in v2
> - Take over the maintainership for the bindings
> - Add interrupt and power supply property in DT bindings
>
> .../bindings/iio/light/liteon,ltrf216a.yaml | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/light/liteon,ltrf216a.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/light/liteon,ltrf216a.yaml b/Documentation/devicetree/bindings/iio/light/liteon,ltrf216a.yaml
> new file mode 100644
> index 000000000000..f256ff2e744c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/liteon,ltrf216a.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/light/liteon,ltrf216a.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LTRF216A Ambient Light Sensor
> +
> +maintainers:
> + - Shreeya Patel <shreeya.patel@collabora.com>
> +
> +description:
> + Ambient light sensing with an i2c interface.
> +
> +properties:
> + compatible:
> + const:
> + - liteon,ltrf216a
I assume you figured this out from the build bot error.
const: liteon,ltrf216a
Please make sure to do what that message from Rob's bot says and test your bindings
before sending v7.
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + vdd-supply:
> + description: Regulator that provides power to the sensor.
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + light-sensor@53 {
> + compatible = "liteon,ltrf216a";
> + reg = <0x53>;
> + vdd-supply = <&vdd_regulator>;
> + interrupt-parent = <&gpio0>;
> + interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
> + };
> + };
next prev parent reply other threads:[~2022-06-19 12:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 13:51 [PATCH v6 0/2] Add LTRF216A Driver Shreeya Patel
2022-06-15 13:51 ` [PATCH v6 1/2] dt-bindings: Document ltrf216a light sensor bindings Shreeya Patel
2022-06-15 17:20 ` Rob Herring
2022-06-19 12:34 ` Jonathan Cameron [this message]
2022-06-19 12:57 ` Shreeya Patel
2022-06-15 13:51 ` [PATCH v6 2/2] iio: light: Add support for ltrf216a sensor Shreeya Patel
2022-06-15 16:32 ` Andy Shevchenko
2022-06-19 12:44 ` Jonathan Cameron
2022-07-06 20:52 ` Dmitry Osipenko
2022-07-06 20:52 ` Dmitry Osipenko
2022-07-06 20:59 ` Dmitry Osipenko
2022-07-06 21:00 ` Dmitry Osipenko
2022-07-06 21:09 ` Dmitry Osipenko
2022-07-06 22:48 ` Shreeya Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220619133415.5b3762d3@jic23-huawei \
--to=jic23@kernel.org \
--cc=Zhigang.Shi@liteon.com \
--cc=alvaro.soliverez@collabora.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shreeya.patel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox