From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4962C433EF for ; Mon, 20 Jun 2022 16:40:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234090AbiFTQku (ORCPT ); Mon, 20 Jun 2022 12:40:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229906AbiFTQkt (ORCPT ); Mon, 20 Jun 2022 12:40:49 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F11DBE15 for ; Mon, 20 Jun 2022 09:40:49 -0700 (PDT) Received: from fraeml704-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4LRb3t4c7jz686DL; Tue, 21 Jun 2022 00:40:26 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml704-chm.china.huawei.com (10.206.15.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2375.24; Mon, 20 Jun 2022 18:40:46 +0200 Received: from localhost (10.202.226.42) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 20 Jun 2022 17:40:46 +0100 Date: Mon, 20 Jun 2022 17:40:44 +0100 From: Jonathan Cameron To: Andy Shevchenko CC: Jonathan Cameron , linux-iio , Peter Rosin , "Michael Hennerich" , Lars-Peter Clausen , Vincent Whitchurch Subject: Re: [PATCH v2 16/17] iio: cdc: ad7746: Move driver out of staging. Message-ID: <20220620174044.000061af@Huawei.com> In-Reply-To: References: <20220619185839.1363503-1-jic23@kernel.org> <20220619185839.1363503-17-jic23@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.42] X-ClientProxiedBy: lhreml748-chm.china.huawei.com (10.201.108.198) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 20 Jun 2022 01:11:36 +0200 Andy Shevchenko wrote: > On Sun, Jun 19, 2022 at 8:59 PM Jonathan Cameron wrote: > > > > From: Jonathan Cameron > > > > All known major issues with this driver resolved so time to move > > it out of staging. > > > > Note this cleanup work was done using the roadtest framework. > > https://lore.kernel.org/all/20220311162445.346685-1-vincent.whitchurch@axis.com/ > > > > Signed-off-by: Jonathan Cameron > > --- > > drivers/iio/cdc/Kconfig | 10 + > > drivers/iio/cdc/Makefile | 1 + > > drivers/iio/cdc/ad7746.c | 818 +++++++++++++++++++++++++++++++ > > drivers/staging/iio/cdc/ad7746.c | 818 ------------------------------- > > It's a bit hard to review, perhaps you forgot to add -M -C when > generating this patch? Specifically passed --no-renames because this is a direct file move - I should have stated that though. The intent is to allow review of the full driver as being proposed for move out of staging. Including the bits that otherwise aren't visible anywhere in the driver. I only do this (and ask for it from others) for staging graduation patches. However, I've just noticed the diff doesn't include removing the entries from drivers/staging/iio/cdc/Kconfig + drivers/staging/iio/cdc/Makefile which is weird. Will check that for v3. Thanks, Jonathan > > (Also note that `git am` able to parse renamings, the only thing which > should be in full in patches is when one deletes the file, although it > may be already supported by newest versions of Git, dunno) >