From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74161C43334 for ; Mon, 20 Jun 2022 19:53:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229749AbiFTTxe (ORCPT ); Mon, 20 Jun 2022 15:53:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbiFTTxb (ORCPT ); Mon, 20 Jun 2022 15:53:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8B9619C3F for ; Mon, 20 Jun 2022 12:53:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6456A61631 for ; Mon, 20 Jun 2022 19:53:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F505C3411B; Mon, 20 Jun 2022 19:53:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655754808; bh=IMdeFzYQ1mLSZrBCJiTAF5cg7K7jo5xuv61owUiLAhU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nAqWbgEfkrcUXOVmJ5yeVnmT4zGaZ4LhNLFvblIfS7RaSU+oxajq+KX6ArU1gQ4tN csWsWVpQq9JsQMAosxq7UN2r1VzH+vycFccyGG1S/Q+hdyNRAkCKYxYP/734Zbx5mS eTe0KxMlTl0rYVEforAFOzrP9Z8A8WapH1R2vRI1sJ+nwJdEwdaTIAiPcC/JK4zJF7 1N1m+oyHPCNJkwfu5xW3CJOjxfgqveDqCEZ1fCHWFoeozTIJtF2O3YNGK3AQfDDr+7 Zl29yGp5caSMIWTL6o6XLmktNWtzeHrRC6bhzbEMNOWIh8B//wOJD/dNqDs/jVS5Va ofvYNDtwDEWBg== Date: Mon, 20 Jun 2022 20:53:22 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Jonathan Cameron , linux-iio , Peter Rosin , Michael Hennerich , Lars-Peter Clausen , Vincent Whitchurch Subject: Re: [PATCH v2 16/17] iio: cdc: ad7746: Move driver out of staging. Message-ID: <20220620205322.737f4a57@jic23-huawei> In-Reply-To: References: <20220619185839.1363503-1-jic23@kernel.org> <20220619185839.1363503-17-jic23@kernel.org> <20220620174044.000061af@Huawei.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 20 Jun 2022 20:40:17 +0200 Andy Shevchenko wrote: > On Mon, Jun 20, 2022 at 6:40 PM Jonathan Cameron > wrote: > > On Mon, 20 Jun 2022 01:11:36 +0200 > > Andy Shevchenko wrote: > > > On Sun, Jun 19, 2022 at 8:59 PM Jonathan Cameron wrote: > > ... > > > > > drivers/iio/cdc/ad7746.c | 818 +++++++++++++++++++++++++++++++ > > > > drivers/staging/iio/cdc/ad7746.c | 818 ------------------------------- > > > > > > It's a bit hard to review, perhaps you forgot to add -M -C when > > > generating this patch? > > > > Specifically passed --no-renames because this is a direct file move - > > I should have stated that though. > > > > The intent is to allow review of the full driver as being proposed for > > move out of staging. > > In (my) practice it only makes review much harder without any > additional benefits. Git is smart to understand renaming and in the > diffstat there is a special line about renaming. > > > Including the bits that otherwise aren't > > visible anywhere in the driver. I only do this (and ask for it from others) > > for staging graduation patches. > > Perhaps somebody finds that useful, but me :-) > I definitely do as lets me lazy and not apply the patches just do a review + where do you comment on something in the original driver that is getting moved? That particularly use case only really applies to drivers moving out of staging though. Alternative is to paste the entire driver in the cover letter which is not a great solution either... Jonathan